Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove the document of the http disk usage api #9329

Merged
merged 2 commits into from
Feb 18, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Feb 17, 2019

What problem does this PR solve?

The http disk usage api is not accurate, it will confuse the user sometimes.

What is changed and how it works?

Remove the introduction of this api in the document. And make some formats.

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch

@codecov-io
Copy link

Codecov Report

Merging #9329 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9329      +/-   ##
==========================================
+ Coverage   67.21%   67.21%   +<.01%     
==========================================
  Files         371      371              
  Lines       77552    77552              
==========================================
+ Hits        52125    52129       +4     
+ Misses      20772    20770       -2     
+ Partials     4655     4653       -2
Impacted Files Coverage Δ
util/systimemon/systime_mon.go 80% <0%> (-20%) ⬇️
executor/executor.go 66.89% <0%> (-0.14%) ⬇️
executor/join.go 78.38% <0%> (ø) ⬆️
ddl/delete_range.go 79.36% <0%> (+4.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09e0e3...0215be9. Read the comment docs.

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 18, 2019
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 18, 2019
Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut merged commit 0e6ce46 into pingcap:master Feb 18, 2019
@jackysp jackysp deleted the remove_disk_api branch April 4, 2019 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/docs status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants