Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: ECB/CBC modes with 128/192/256-bit key length for AES (#7425) #9344

Merged
merged 5 commits into from
Feb 21, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

#cherry-pick #7425
This is a patch for client. DNM.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

@crazycs520
Copy link
Contributor Author

@zz-jason @lysu PTAL

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu
Copy link
Contributor

lysu commented Feb 18, 2019

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 19, 2019
@crazycs520 crazycs520 closed this Feb 19, 2019
@crazycs520 crazycs520 reopened this Feb 21, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

@crazycs520
Copy link
Contributor Author

@zz-jason Let's merge this to release2.0

@jackysp jackysp merged commit 2de0e5f into pingcap:release-2.0 Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants