Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx/variable: Add correctness check when set system variables (#7117), (#8876) #9413

Merged
merged 3 commits into from
Feb 22, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Feb 21, 2019

What problem does this PR solve?

Cherry-pick #7117,#8876

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

@crazycs520 crazycs520 added type/2.0 cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Feb 21, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

@crazycs520
Copy link
Contributor Author

@jackysp @tiancaiamao PTAL

@crazycs520 crazycs520 changed the title sessionctx/variable: Add correctness check when set system variables sessionctx/variable: Add correctness check when set system variables (#7117), (#8876) Feb 22, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2019
Copy link
Contributor

@xiekeyi98 xiekeyi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 08cde60 into pingcap:release-2.0 Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants