Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl:show full columns for date, datetime, timestamp compatibility (#9810) #9938

Merged
merged 2 commits into from
Mar 28, 2019

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Mar 28, 2019

What problem does this PR solve?

cherry-pick #9810 to v2.1

Related PR: pingcap/tidb-test#768

@zimulala
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@zimulala
Copy link
Contributor Author

PTAL @crazycs520 @bb7133 @xiekeyi98

@bb7133
Copy link
Member

bb7133 commented Mar 28, 2019

LGTM

@xiekeyi98
Copy link
Contributor

/run-common-test tidb-test=pr/768

@zimulala
Copy link
Contributor Author

/run-integration-common-test tidb-test=pr/768

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2019
Copy link
Contributor

@xiekeyi98 xiekeyi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 28, 2019
@zimulala zimulala merged commit 530aa06 into pingcap:release-2.1 Mar 28, 2019
@zimulala zimulala deleted the show-full branch March 28, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants