Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support group concat #2539

Merged
merged 28 commits into from
Aug 30, 2021
Merged

support group concat #2539

merged 28 commits into from
Aug 30, 2021

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Aug 2, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #1908

Problem Summary:

What is changed and how it works?

Proposal: implemention doc

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

Release note 

support group_concat

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 9, 2021
@fzhedu fzhedu requested review from windtalker and fuzhe1989 and removed request for windtalker August 9, 2021 10:20
@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 9, 2021

/run-all-tests

@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 9, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 10, 2021
@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 10, 2021

/run-all-tests

@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 11, 2021

/run-all-tests

5 similar comments
@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 11, 2021

/run-all-tests

@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 12, 2021

/run-all-tests

@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 12, 2021

/run-all-tests

@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 12, 2021

/run-all-tests

@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 12, 2021

/run-all-tests

@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 12, 2021

/rebuild

@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 13, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2021
@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 19, 2021

/run-all-tests

2 similar comments
@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 19, 2021

/run-all-tests

@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 19, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2021
@fzhedu fzhedu requested a review from fuzhe1989 August 30, 2021 04:37
@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 30, 2021

/run-all-tests

@fzhedu
Copy link
Contributor Author

fzhedu commented Aug 30, 2021

/merge

@ti-chi-bot
Copy link
Member

@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 61c9aa4

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 30, 2021
@ti-chi-bot ti-chi-bot merged commit 886d7bc into pingcap:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support group concat distinct agg function push down
4 participants
@fzhedu @ti-chi-bot @windtalker @fuzhe1989