Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename theflash #407

Merged
merged 1 commit into from
Feb 4, 2020
Merged

rename theflash #407

merged 1 commit into from
Feb 4, 2020

Conversation

marsishandsome
Copy link
Contributor

@marsishandsome marsishandsome commented Feb 4, 2020 •
edited
Loading

@marsishandsome marsishandsome mentioned this pull request Feb 4, 2020
Merged
@marsishandsome
Copy link
Contributor Author

/run-integration-tests

@zanmato1984
Copy link
Contributor

How about we rename the cmake target name from theflash to tiflash?

ilovesoup
ilovesoup approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome merged commit bd7662d into pingcap:master Feb 4, 2020
@marsishandsome marsishandsome mentioned this pull request Feb 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilovesoup ilovesoup ilovesoup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marsishandsome @zanmato1984 @ilovesoup