Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorter: correct wrong metric about next duration #11577

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Sep 9, 2024

What problem does this PR solve?

Issue Number: close #11576

What is changed and how it works?

Correct a metric.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2024
@hicqu
Copy link
Contributor Author

hicqu commented Sep 9, 2024

/rebuild

@hicqu hicqu added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Sep 9, 2024
@hicqu
Copy link
Contributor Author

hicqu commented Sep 9, 2024

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 9, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-09 08:22:24.557697253 +0000 UTC m=+258214.298121192: ☑️ agreed by 3AceShowHand.
  • 2024-09-09 08:27:45.003852157 +0000 UTC m=+258534.744276095: ☑️ agreed by CharlesCheung96.

@hicqu
Copy link
Contributor Author

hicqu commented Sep 9, 2024

/retest

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.4763%. Comparing base (f74f863) to head (08d90bd).
Report is 2 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.2270% <66.6666%> (+0.0348%) ⬆️
dm 51.0334% <ø> (-0.0081%) ⬇️
engine 63.4232% <ø> (+0.0353%) ⬆️
Flag Coverage Δ
unit 57.4763% <66.6666%> (+0.0179%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11577        +/-   ##
================================================
+ Coverage   57.4584%   57.4763%   +0.0179%     
================================================
  Files           851        851                
  Lines        126495     126492         -3     
================================================
+ Hits          72682      72703        +21     
+ Misses        48404      48385        -19     
+ Partials       5409       5404         -5     

@hicqu
Copy link
Contributor Author

hicqu commented Sep 9, 2024

/retest

1 similar comment
@hicqu
Copy link
Contributor Author

hicqu commented Sep 9, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 50659c4 into pingcap:master Sep 9, 2024
28 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11581.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 9, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11582.

@hicqu hicqu deleted the fix-pebble-next-metric branch September 9, 2024 11:49
wk989898 pushed a commit to wk989898/tiflow that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pebbledb sorter metric next is wrong
4 participants