api(ticdc): Not show the error info during query the changefeed when state is stopped, finished and removed #11641
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
size/XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11641 +/- ##
================================================
- Coverage 55.2635% 55.2613% -0.0022%
================================================
Files 1001 1001
Lines 136162 136162
================================================
- Hits 75248 75245 -3
- Misses 55426 55430 +4
+ Partials 5488 5487 -1 |
|
@hongyunyan: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -284,7 +284,7 @@ func (h *OpenAPIV2) listChangeFeeds(c *gin.Context) { | |||
|
|
|||
| // if the state is normal, we shall not return the error info | |||
| // because changefeed will is retrying. errors will confuse the users | |||
| if commonInfo.FeedState == model.StateNormal { | |||
| if commonInfo.FeedState == model.StateNormal || commonInfo.FeedState == model.StateStopped || commonInfo.FeedState == model.StateFinished || commonInfo.FeedState == model.StateRemoved { | |||
There was a problem hiding this comment.
too complex here, exact it to a function, then use it in line 1039
What problem does this PR solve?
Issue Number: close #11642
What is changed and how it works?
Make the previous error message not return when changefeed state is stopped / finished / removed, to avoid confused.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note