test(dm): enable new charset for TiDB in test #3736
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
|
/run-dm-integration-test |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #3736 +/- ##
================================================
+ Coverage 57.3452% 57.5170% +0.1718%
================================================
Files 460 461 +1
Lines 54927 55321 +394
================================================
+ Hits 31498 31819 +321
- Misses 20180 20239 +59
- Partials 3249 3263 +14 |
|
/run-dm-integration-test |
|
/run-dm-integration-test |
ti-chi-bot
added
size/L
|
/run-dm-integration-test |
lance6716
changed the title
ti-chi-bot
added
the
do-not-merge/work-in-progress
|
/run-dm-integration-test |
1 similar comment
|
/run-dm-integration-test |
lance6716
force-pushed
the
enable-new-charset
branch
from
bb13e4a
to
5c91575
Compare
|
/run-dm-integration-test |
lance6716
force-pushed
the
enable-new-charset
branch
from
5c91575
to
40c627a
Compare
|
/run-dm-integration-test |
|
/run-dm-integration-test |
1 similar comment
|
/run-dm-integration-test |
lance6716
force-pushed
the
enable-new-charset
branch
from
e4bc685
to
d9900c0
Compare
|
/run-dm-integration-test |
|
/run-dm-integration-test |
lance6716
changed the title
ti-chi-bot
removed
the
do-not-merge/work-in-progress
|
/run-dm-integration-test |
| # turn on collation framework https://docs.pingcap.com/tidb/stable/character-set-and-collation#new-framework-for-collations | ||
| rm $tmp_config || true | ||
| cat >$tmp_config <<EOF | ||
| new_collations_enabled_on_first_bootstrap = true |
There was a problem hiding this comment.
why not let cases which depends on this flag opens it separately?
There was a problem hiding this comment.
change the default test behaviour to avoid we forget collation compatibility in future (such as a new developer add a test and reviews forget checking collation).
| echo "check data" | ||
| check_sync_diff $WORK_DIR $cur/conf/diff_config.toml | ||
| mv "$cur/conf/task-ca.pem.bak" "$cur/conf/task-ca.pem" | ||
| # TODO: revert this when lightning support tls |
There was a problem hiding this comment.
you can comment the whole test test_worker_ha_when_enable_source_tls 😂
There was a problem hiding this comment.
hope you can finish it soon so we'll revert it soon😂
|
@D3Hunter: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
LGTM |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: f0927fe
|
ti-chi-bot
added
the
status/can-merge
|
/run-integration-test |
|
@lance6716: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-dm-integration-tests |
|
/run-dm-integration-test |
What problem does this PR solve?
enable new charset for TiDB in test, so we can test about charset and collations
also include pingcap/tidb#30173 pingcap/tidb#30292 pingcap/tidb#29291
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note