Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(cdc): fix the check about resolvedTs and checkpointTs (#9772) #9776

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9772

What problem does this PR solve?

Issue Number: close #9769

What is changed and how it works?

  • make owner scheduler broadcast correct ResolvedTs if redo is enbaled;
  • correct the check about comparing resolvedTs and checkpointTs in processor;

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Sep 20, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 21, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu hicqu force-pushed the cherry-pick-9772-to-release-6.5 branch from 6257b98 to ec7d914 Compare September 23, 2023 04:57
@hicqu
Copy link
Contributor

hicqu commented Sep 23, 2023

/lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hicqu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 23, 2023
@hicqu hicqu merged commit b2ee1e8 into pingcap:release-6.5 Sep 23, 2023
9 checks passed
@hicqu hicqu deleted the cherry-pick-9772-to-release-6.5 branch September 23, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants