Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tab to align output of all levels #135

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Use tab to align output of all levels #135

merged 1 commit into from
Oct 5, 2020

Conversation

dublx
Copy link
Contributor

@dublx dublx commented Oct 1, 2020 •
edited
Loading

Improves on #47

Same visual result but the trailing spaces in INFO and WARN constants were removed.

$ node example.js | pino-pretty
[1601561263881] INFO	 (39775 on nf.lan): Ini
[1601561263881] ERROR	 (39775 on nf.lan): Miny
[1601561263881] WARN	 (39775 on nf.lan): Mo!

@dublx
Use tab to align output of all levels
d88283c 
Use tab to align output of all levels instead of a single space to align only INFO/WARN levels
mcollina
mcollina approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jsumners
jsumners approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zirak what do you think?

@Zirak
Copy link
Contributor

Zirak commented Oct 4, 2020

LGTM! Whatever helps reading a truckload of logs quickly.

@mcollina mcollina merged commit ec09288 into pinojs:master Oct 5, 2020
@jsumners jsumners mentioned this pull request Dec 15, 2020
Closed
arthurw1 added a commit to arthurw1/pino-pretty that referenced this pull request Dec 29, 2020
@arthurw1
Revert "Use tab to align output of all levels (pinojs#135)"
ecf1904 
This reverts commit ec09288.
@arthurw1 arthurw1 mentioned this pull request Dec 30, 2020
Merged
arthurw1 added a commit to arthurw1/pino-pretty that referenced this pull request Jan 27, 2021
@arthurw1
Revert "Use tab to align output of all levels (pinojs#135)"
7e607c9 
This reverts commit ec09288.
jsumners pushed a commit that referenced this pull request Jan 30, 2021
@arthurw1
Fix/remove extra space (#141)
f66c674 
* Revert "Use tab to align output of all levels (#135)"

This reverts commit ec09288.

* Fix test

* Remove all spaces for log level constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dublx @Zirak @mcollina @jsumners