Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RTC prefix from library types #408

Closed
maxhawkins opened this issue Feb 15, 2019 · 0 comments
Closed

Remove RTC prefix from library types #408

maxhawkins opened this issue Feb 15, 2019 · 0 comments
Assignees
@maxhawkins
Milestone
2.0.0 (Spear of D...

Comments

@maxhawkins
Copy link
Contributor

Example:

webrtc.RTCTrack -> webrtc.Track
webrtc.RTCPeerConnection -> webrtc.PeerConnection
  • Reduces studdering: webrtc.RTCTrack -> webrtc.Track
  • Makes it easier to find types by editor autocomplete
  • Makes code read more fluently (less repetition)
maxhawkins added a commit that referenced this issue Feb 15, 2019
@maxhawkins
Pull off the bandaid: Remove RTC prefix from all names
b92b9a5 
* Reduces studdering: webrtc.RTCTrack -> webrtc.Track
* Makes it easier to find types by editor autocomplete
* Makes code read more fluently (less repetition)

Since we're breaking the API in 2.0, our only chance to
do this is now!

Relates to #408
@maxhawkins maxhawkins mentioned this issue Feb 15, 2019
Merged
maxhawkins added a commit that referenced this issue Feb 15, 2019
@maxhawkins
Remove RTC prefix from all names
45bb53e 
Let's pull off the bandaid!

* Reduces studdering: webrtc.RTCTrack -> webrtc.Track
* Makes it easier to find types by editor autocomplete
* Makes code read more fluently (less repetition)

Since we're breaking the API in 2.0, our only chance to
do this is now.

Relates to #408
maxhawkins added a commit that referenced this issue Feb 15, 2019
@maxhawkins
Remove rtc prefix from filenames
8bd7a15 
Relates to #408
@Sean-Der Sean-Der added this to the 2.0.0 (Spear of Destiny) milestone Feb 17, 2019
maxhawkins added a commit that referenced this issue Feb 17, 2019
@maxhawkins
Remove RTC prefix from all names
600795b 
Let's pull off the bandaid!

* Reduces studdering: webrtc.RTCTrack -> webrtc.Track
* Makes it easier to find types by editor autocomplete
* Makes code read more fluently (less repetition)

Since we're breaking the API in 2.0, our only chance to
do this is now.

Relates to #408
maxhawkins added a commit that referenced this issue Feb 17, 2019
@maxhawkins
Remove rtc prefix from filenames
b347665 
Relates to #408
maxhawkins added a commit that referenced this issue Feb 17, 2019
@maxhawkins
Test SetConfiguration with ICECandidatePoolSize
030b84f 
Also reformat unit test to add test names so it's easier to track
individual test cases in the table-driven test.

Increases test coverage in peerconnection.go. Enough for us to merge?

Relates to #408
maxhawkins added a commit that referenced this issue Feb 18, 2019
@maxhawkins
Remove RTC prefix from all names
0e7086d 
Let's pull off the bandaid!

* Reduces studdering: webrtc.RTCTrack -> webrtc.Track
* Makes it easier to find types by editor autocomplete
* Makes code read more fluently (less repetition)

Since we're breaking the API in 2.0, our only chance to
do this is now.

Relates to #408
maxhawkins added a commit that referenced this issue Feb 18, 2019
@maxhawkins
Remove rtc prefix from filenames
0647ce9 
Relates to #408
maxhawkins added a commit that referenced this issue Feb 18, 2019
@maxhawkins
Test SetConfiguration with ICECandidatePoolSize
b2fcef1 
Also reformat unit test to add test names so it's easier to track
individual test cases in the table-driven test.

Increases test coverage in peerconnection.go. Enough for us to merge?

Relates to #408
Antonito pushed a commit to Antonito/webrtc that referenced this issue Feb 26, 2019
@maxhawkins
Remove RTC prefix from all names
f5debe5 
Let's pull off the bandaid!

* Reduces studdering: webrtc.RTCTrack -> webrtc.Track
* Makes it easier to find types by editor autocomplete
* Makes code read more fluently (less repetition)

Since we're breaking the API in 2.0, our only chance to
do this is now.

Relates to pion#408
Antonito pushed a commit to Antonito/webrtc that referenced this issue Feb 26, 2019
@maxhawkins
Remove rtc prefix from filenames
0e53e42 
Relates to pion#408
Antonito pushed a commit to Antonito/webrtc that referenced this issue Feb 26, 2019
@maxhawkins
Test SetConfiguration with ICECandidatePoolSize
0e22c3b 
Also reformat unit test to add test names so it's easier to track
individual test cases in the table-driven test.

Increases test coverage in peerconnection.go. Enough for us to merge?

Relates to pion#408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxhawkins maxhawkins

Labels
None yet
Milestone
2.0.0 (Spear of Destiny)
Development

No branches or pull requests
2 participants
@maxhawkins @Sean-Der