Added ability to set random gcloud dir name.

piotrmadry · Oct 22, 2018 · 6dfdc3e · 6dfdc3e
1 parent 55d89f4
commit 6dfdc3e
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -86,6 +86,7 @@ firebaseTestLab {
 
     // If you prefer you can use your custom google storage bucket for storing build sources and results
     // cloudBucketName = "your-custome-google-storage-bucket-name"
+    // If not specified default is: a timestamp with a random suffix
     // cloudDirectoryName = "your-custome-directory-name"
 
     // If you prefer to install gcloud tool manually you can set path by

diff --git a/plugin/build.gradle b/plugin/build.gradle
@@ -5,8 +5,7 @@ apply plugin: "maven"
 apply plugin: "com.gradle.plugin-publish"
 
 group = "firebase.test.lab"
-version = "1.1.5"
-
+version = "1.1.6"
 
 gradlePlugin {
     plugins {

diff --git a/plugin/src/main/java/com/appunite/firebasetestlabplugin/FirebaseTestLabPlugin.kt b/plugin/src/main/java/com/appunite/firebasetestlabplugin/FirebaseTestLabPlugin.kt
@@ -174,7 +174,7 @@ internal class FirebaseTestLabPlugin : Plugin<Project> {
                 CloudTestResultDownloader(
                         sdk,
                         resultsTypes,
-                        File(cloudDirectoryName),
+                        File(cloudDirectoryName ?: ""),
                         File(project.buildDir, cloudDirectoryName),
                         cloudBucketName!!,
                         project.logger
@@ -184,7 +184,7 @@ internal class FirebaseTestLabPlugin : Plugin<Project> {
             }
 
             if (clearDirectoryBeforeRun && downloader == null) {
-                throw IllegalStateException("If you want to clear directory before run you need to setup cloudBucketName")
+                throw IllegalStateException("If you want to clear directory before run you need to setup cloudBucketName and cloudDirectoryName")
             }
 
             val firebaseTestLabProcessCreator = FirebaseTestLabProcessCreator(

diff --git a/plugin/src/main/java/com/appunite/firebasetestlabplugin/FirebaseTestLabPluginExtension.kt b/plugin/src/main/java/com/appunite/firebasetestlabplugin/FirebaseTestLabPluginExtension.kt
@@ -9,16 +9,12 @@ import java.io.File
 
 open class FirebaseTestLabPluginExtension(private val project: Project) {
 
-    companion object {
-        private val DEFAULT_DIRECTORY_NAME = "androidTestResults"
-    }
-
     var keyFile: File? = null
     var googleProjectId: String? = null
     var cloudSdkPath: String? = null
 
     var cloudBucketName: String? = null
-    var cloudDirectoryName: String = DEFAULT_DIRECTORY_NAME
+    var cloudDirectoryName: String? = null
 
     var clearDirectoryBeforeRun = false
     var ignoreFailures: Boolean = false