Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #4866 #4851 #4801 #4872 #4875 #4855 #4869 #4877 #4878 #4882 #4883 #4887 #4885 #4886 #4884 #4880 #4890

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a caution comment of scrape_interval (#4869)
* Add caution comment of scrape_interval

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Remove concrete value

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Fix to commit hash of v0.47.0 to fix the ref position

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
  • Loading branch information
t-kikuc authored and khanhtc1202 committed Apr 22, 2024
commit 72158cba0231891fc6180eeaeb9bf17e08c93478
2 changes: 2 additions & 0 deletions manifests/pipecd/templates/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,8 @@ data:
replacement: $1

- job_name: pipecd-ops
# This scrape_interval must not be larger than the interval of piped's stats-reporting.
# ref: https://github.com/pipe-cd/pipecd/blob/a73d0913643ef1da05bc8898cf055c9893f16e0b/pkg/app/piped/statsreporter/reporter.go#L53
scrape_interval: 1m
kubernetes_sd_configs:
- role: endpoints
Expand Down