Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support skipping stages by path pattern or commit message prefix #4922

Merged
merged 51 commits into from
Jun 18, 2024
Merged

Support skipping stages by path pattern or commit message prefix #4922

Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
06c5f5d
rename func to distinguish the trigger of skip stage
t-kikuc Apr 22, 2024
022e940
Draft: impl check of skipping stage
t-kikuc Apr 22, 2024
59b14ab
Rename to 'prefixes'
t-kikuc Apr 29, 2024
691db8a
separate to sub funcs
t-kikuc Apr 29, 2024
7c37add
Impl Repo.GetCommitFromRev
t-kikuc Apr 29, 2024
ced6054
Impl skipByPathPattern()
t-kikuc Apr 29, 2024
3809d14
Add skipOn options to Wait Stage Options
t-kikuc Apr 29, 2024
7d7f9b7
Add check of skipping stage in Analysis,Wait,WaitApproval Stages
t-kikuc Apr 29, 2024
c4a529d
Fix comments
t-kikuc Apr 29, 2024
e925ef7
draft: add an empty test file
t-kikuc Apr 30, 2024
ee89a23
fix comments
t-kikuc May 19, 2024
87efcd5
Fix func name
t-kikuc May 22, 2024
79fe4c5
Rename struct from confusing one
t-kikuc May 22, 2024
faf376d
Refine order of args
t-kikuc May 22, 2024
152e82f
add test of hasOnlyPathsToSkip
t-kikuc May 22, 2024
2532f42
Refine testcase names
t-kikuc May 22, 2024
8329c41
rename 'expected' to 'skip'
t-kikuc May 22, 2024
a7c87b4
Fix testcases
t-kikuc May 22, 2024
f3fa841
separate func
t-kikuc May 22, 2024
41e136b
add test for skipByCommitMessagePrefixes
t-kikuc May 22, 2024
794e2e5
Moved package to new 'skipstage'
t-kikuc May 22, 2024
06641de
Add SkipOptions to ScriptRunStageOptions
t-kikuc May 22, 2024
fbb350f
rename 'SkipOptions' to 'SkipOn' to match with yaml
t-kikuc May 22, 2024
817830a
Move skip logic to scheduler
t-kikuc May 22, 2024
94618f9
Add missing reporting
t-kikuc May 22, 2024
e9caff2
Merge branch 'master' of https://github.com/pipe-cd/pipecd into skip-…
t-kikuc May 22, 2024
5b3585e
fix nits
t-kikuc May 22, 2024
5c46fe5
Fix check logic
t-kikuc May 22, 2024
2e4c9df
Add missing error handling
t-kikuc May 22, 2024
a687cd7
Move skipstage to controller
t-kikuc May 22, 2024
431682c
Update docs
t-kikuc May 22, 2024
3f0c007
gen mock by 'make gen/code'
t-kikuc May 22, 2024
d59b686
Merge branch 'master' of https://github.com/pipe-cd/pipecd into skip-…
t-kikuc May 29, 2024
b465c66
nits: fix from 'fromCmd' to 'byCmd'
t-kikuc May 30, 2024
674ea92
nits: rename func
t-kikuc May 30, 2024
ea2858a
nits: refine configuration-reference
t-kikuc May 30, 2024
fb4d46b
fix error logging of zap.Error(err)
t-kikuc May 30, 2024
c01b667
fix the flow in error handling
t-kikuc May 30, 2024
6fe1325
Fix: check skipping before creating executor
t-kikuc May 30, 2024
4e67ccb
Remove unused func 'GetCommitHashForRev'
t-kikuc May 30, 2024
e2e35f4
fix: remove unnecessary formatting
t-kikuc May 30, 2024
cab3539
refactor: quit separating 'skipstage' package
t-kikuc May 30, 2024
7eda335
fix: make 'checkSkipStage()' private after refactoring
t-kikuc May 30, 2024
b9e8a2a
Fix: rename test func
t-kikuc May 30, 2024
8a96a8c
Refactor: merge func 'checkSkipStage' into 'shouldSkipStage'
t-kikuc Jun 10, 2024
27e4acd
Merge funcs
t-kikuc Jun 10, 2024
38fae58
Add TestSkipByCommitMessagePrefixes with mock
t-kikuc Jun 10, 2024
0b074fb
Refactore: merge funcs and use mock
t-kikuc Jun 10, 2024
b63c1b1
Merge branch 'master' into skip-stage
t-kikuc Jun 10, 2024
cb6fd10
Merge branch 'master' into skip-stage
t-kikuc Jun 10, 2024
e498822
Merge branch 'master' into skip-stage
t-kikuc Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' of https://github.com/pipe-cd/pipecd into skip-… 
…stage

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
  • Loading branch information
@t-kikuc
t-kikuc committed May 22, 2024
commit e9caff2831bb67f7b390deed06e5df17c99c8efe

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.