Update codegen image version #4970

ffjlabo · 2024-06-13T02:40:06Z

What this PR does / why we need it:

Update codegen image version on gen/code

Which issue(s) this PR fixes:

Part of #4874
Related to #4968

Does this PR introduce a user-facing change?:

How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

ffjlabo · 2024-06-13T02:43:50Z

gen/code failed 😇 I will investigate it.
https://github.com/pipe-cd/pipecd/actions/runs/9492831530/job/26160595802?pr=4970

codecov · 2024-06-13T02:44:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.33%. Comparing base (462b842) to head (b06e221).

❗ Current head b06e221 differs from pull request most recent head f609eae

Please upload reports for the commit f609eae to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4970      +/-   ##
==========================================
+ Coverage   29.32%   29.33%   +0.01%     
==========================================
  Files         323      323              
  Lines       40984    40984              
==========================================
+ Hits        12017    12024       +7     
+ Misses      28005    27999       -6     
+ Partials      962      961       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Warashi · 2024-06-13T02:44:47Z

Makefile

@@ -199,7 +199,7 @@ update/copyright:
 .PHONY: gen/code
 gen/code:
 	# NOTE: Specify a specific version temporally until the next release.
-	docker run --rm -v ${PWD}:/repo -it --entrypoint ./tool/codegen/codegen.sh ghcr.io/pipe-cd/codegen@sha256:fc3db505ef8dbf287b90aafed8c28246d2cca06bda2b43893a3059719fe9fff4 /repo #v0.44.0-38-g7229285
+	docker run --rm -v ${PWD}:/repo -it --entrypoint ./tool/codegen/codegen.sh ghcr.io/pipe-cd/codegen:v0.47.3-rc0-1-g7e27cad /repo


How about specifying the image with sha256 hash, as specified in the PR's base commit?

I see.
Is the sha256 hash better than specifying version?
I don't have a strong opinion, but I felt redundant hash with version comment like the base commit.

The image specified with the tag can be overwritten, such as the git tag.
Conversely, the sha256 hash is immutable, such as the git commit hash.
So, specifying with the sha256 hash is more reproducible.

I got your point! Thank you! I'll fix it.

khanhtc1202 · 2024-06-13T02:51:45Z

@ffjlabo You have to update this line in order to make the CI passed
https://github.com/pipe-cd/pipecd/blob/master/.github/workflows/gen.yaml#L14

ffjlabo · 2024-06-13T02:53:05Z

oops sorry 🙏

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

ffjlabo · 2024-06-13T03:27:52Z

Workflow still failed 🤔
https://github.com/pipe-cd/pipecd/actions/runs/9492993824

docker://ghcr.io/pipe-cd/codegen@sha256:277a911717e5bd33aca7b38f05dd8ab4a047ba5038a81f9b43d816a5a921fe84 is not allowed to be used in pipe-cd/pipecd. Actions in this workflow must be: within a repository that belongs to your Enterprise account or matching the following: actions/cache@v2, actions/setup-go@v2, Azure/setup-helm@v1, actions/setup-node@v3, peaceiris/actions-hugo@c03b5dbed22245418539b65eb9a3b1d5fdd9a0a6, softprops/action-gh-release@1e07f4398721186383de40550babbdf2b84acfc5, actions/labeler@v4, reviewdog/action-golangci-lint@f3dc5fadcaff5d8da3574b129a58db433171b1a8, actions/checkout@v3, docker/login-action@49ed152c8eca782a232dede0303416e8f356c37b, actions/setup-go@v3, contributor-assistant/github-action@b3bbab0a75fa27270069933cec6f369c0b373b4e, pipe-cd/actions-gh-release@v2.4.0, github/codeql-action/analyze@v2, github/codeql-action/autobuild@v2, github/codeql-action/init@v2, codecov/codecov-action@v3, docker/setup-qemu-action@8b122486cedac8393e77aa9734c3528886e4a1a8, docker...

docker://ghcr.io/pipe-cd/codegen@sha256:277a911717e5bd33aca7b38f05dd8ab4a047ba5038a81f9b43d816a5a921fe84 is not allowed to be used in pipe-cd/pipecd. Actions in this workflow must be: within a repository that belongs to your Enterprise account or matching the following

Maybe need to fix the actions setting for the repo

ffjlabo · 2024-06-13T03:43:51Z

I tried to add the docker://ghcr.io/pipe-cd/codegen@sha256:277a911717e5bd33aca7b38f05dd8ab4a047ba5038a81f9b43d816a5a921fe84 to the Actions permissions in the setting.

So lets recheck.

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

ffjlabo · 2024-06-13T04:00:28Z

CI failed because there is the diff in pkg/app/server/service/webservice/service.pb.auth.go.

https://github.com/pipe-cd/pipecd/actions/runs/9493373712/job/26161960073?pr=4970

HEAD detached at pull/4970/merge
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   pkg/app/server/service/webservice/service.pb.auth.go

Also encountered the problem on my local machine using the image 🤔

khanhtc1202 · 2024-06-13T05:23:49Z

So with the new codegen image, the generated auth file still not the same as last time succeed 🤔 Which diff is generated? 👀

ffjlabo · 2024-06-13T05:28:58Z

@khanhtc1202
This is the diff. Some methods disappear 🤔

khanhtc1202 · 2024-06-13T05:30:24Z

So this issue remained 🥹
#4963

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

ffjlabo · 2024-06-14T02:37:49Z

CI gen passed!
https://github.com/pipe-cd/pipecd/actions/runs/9509753883/job/26213180311?pr=4970

khanhtc1202 · 2024-06-14T02:41:53Z

.github/workflows/gen.yaml

+    - name: check CPU architecture
+      shell: bash
+      run: cat /proc/cpuinfo && uname -a


Do we still need this?

Sorry, I forgot to remove this.
removed b06e221

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

Warashi · 2024-06-14T02:45:38Z

.github/workflows/gen.yaml

+    - name: check CPU architecture
+      shell: bash
+      run: cat /proc/cpuinfo && uname -a


This step is for debugging?
We can add this on demand, so we don't have to include this step in the usual run.

oops, you already removed this. thank you.

Warashi

Thank you!

khanhtc1202

Here you go 👍

* Update codegen image version Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Update codegen image hash in the CI Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix to use image hash in Makefile Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * For checking cpu arch Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix codegen image hash Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Remove checking cpu arch Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> --------- Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>

Update codegen image version

5974ae4

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

ffjlabo requested review from nghialv, khanhtc1202, kentakozuka, t-kikuc and Warashi as code owners June 13, 2024 02:40

github-actions bot added the area/build label Jun 13, 2024

Warashi reviewed Jun 13, 2024

View reviewed changes

Update codegen image hash in the CI

206c510

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

ffjlabo force-pushed the update-codegen-image-hash branch from 5a98931 to af679eb Compare June 13, 2024 03:22

Fix to use image hash in Makefile

2988d0b

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

ffjlabo force-pushed the update-codegen-image-hash branch from af679eb to 2988d0b Compare June 13, 2024 03:45

khanhtc1202 previously approved these changes Jun 13, 2024

View reviewed changes

For checking cpu arch

3624aed

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

ffjlabo dismissed khanhtc1202’s stale review via 3624aed June 13, 2024 10:47

ffjlabo mentioned this pull request Jun 14, 2024

Add empty line to fix the CI gen #4972

Merged

Fix codegen image hash

c9958c5

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

ffjlabo requested review from Warashi and khanhtc1202 June 14, 2024 02:38

khanhtc1202 reviewed Jun 14, 2024

View reviewed changes

Remove checking cpu arch

b06e221

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>

Warashi reviewed Jun 14, 2024

View reviewed changes

Warashi approved these changes Jun 14, 2024

View reviewed changes

ffjlabo requested a review from khanhtc1202 June 14, 2024 02:47

Merge branch 'master' into update-codegen-image-hash

f609eae

khanhtc1202 approved these changes Jun 14, 2024

View reviewed changes

ffjlabo merged commit 6b8c6e2 into master Jun 14, 2024
14 of 16 checks passed

ffjlabo deleted the update-codegen-image-hash branch June 14, 2024 02:52

github-actions bot mentioned this pull request Jul 4, 2024

Release v0.48.0 #5023

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update codegen image version #4970

Update codegen image version #4970

ffjlabo commented Jun 13, 2024

ffjlabo commented Jun 13, 2024

codecov bot commented Jun 13, 2024 •

edited

Loading

Warashi Jun 13, 2024

ffjlabo Jun 13, 2024

Warashi Jun 13, 2024

ffjlabo Jun 13, 2024

khanhtc1202 commented Jun 13, 2024

ffjlabo commented Jun 13, 2024

ffjlabo commented Jun 13, 2024

ffjlabo commented Jun 13, 2024

ffjlabo commented Jun 13, 2024 •

edited

Loading

khanhtc1202 commented Jun 13, 2024

ffjlabo commented Jun 13, 2024

khanhtc1202 commented Jun 13, 2024

ffjlabo commented Jun 14, 2024

khanhtc1202 Jun 14, 2024

ffjlabo Jun 14, 2024

Warashi Jun 14, 2024

Warashi Jun 14, 2024

Warashi left a comment

khanhtc1202 left a comment

Update codegen image version #4970

Update codegen image version #4970

Conversation

ffjlabo commented Jun 13, 2024

ffjlabo commented Jun 13, 2024

codecov bot commented Jun 13, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

khanhtc1202 commented Jun 13, 2024

ffjlabo commented Jun 13, 2024

ffjlabo commented Jun 13, 2024

ffjlabo commented Jun 13, 2024

ffjlabo commented Jun 13, 2024 • edited Loading

khanhtc1202 commented Jun 13, 2024

ffjlabo commented Jun 13, 2024

khanhtc1202 commented Jun 13, 2024

ffjlabo commented Jun 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Warashi left a comment

Choose a reason for hiding this comment

khanhtc1202 left a comment

Choose a reason for hiding this comment

codecov bot commented Jun 13, 2024 •

edited

Loading

ffjlabo commented Jun 13, 2024 •

edited

Loading