Improved compatibility with "How Many Times Can I Back?" (#397) #554
Conversation
"getCommonAncestor" method is not available without jQuery
|
Oops, I think I wanted to use DOMRange#commonAncestorContainer. |
| let container = containerFinder.getCommonAncestor(); | ||
| let containerFinder = namedNodes.closeAnchor; | ||
| let containers = []; | ||
| while (containerFinder != aTab) { |
There was a problem hiding this comment.
In this project, I use the style:
while (...)
{
instead of
while (...) {
for "while", "for", "switch" blocks. So, in the future, please fit your patch to existing styles ;-)
|
One more. I basically use "git style" for commit messages in this project. |
use commonAncestorContainer instead of getCommonAncestor()
|
Oh, sorry. |
Improved compatibility with "How Many Times Can I Back?" (#397)
|
Thanks a lot! BTW, I hope you to cancel the old pull request (like this) and re-send new pull request without unnecessary commit (like 1a83376), In the next time. |
|
You can rewrite commit message without creating a new pull request by |
|
Thank you for all of the advice! |
"getCommonAncestor" method is not available without jQuery