Revert "more files"

This reverts commit 233139b.
pixiebrix · Aug 19, 2024 · 1b2fe11 · 1b2fe11
1 parent f88df33
commit 1b2fe11
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 32 deletions.
diff --git a/src/pageEditor/tabs/editTab/dataPanel/BrickDataPanel.test.tsx b/src/pageEditor/tabs/editTab/dataPanel/BrickDataPanel.test.tsx
@@ -34,7 +34,7 @@ bricksRegistry.register([echoBrick]);
 const { formState, records } = formStateWithTraceDataFactory();
 const renderDataPanel = () => {
   const modComponentId = formState.uuid;
-  const { instanceId } = formState.modComponent.brickPipeline[1]!;
+  const { instanceId } = formState.modComponent.brickPipeline[1];
 
   return render(<BrickDataPanel />, {
     initialValues: formState,
@@ -47,7 +47,7 @@ const renderDataPanel = () => {
           records,
         }),
       );
-      dispatch(editorActions.setActiveNodeId(instanceId!));
+      dispatch(editorActions.setActiveNodeId(instanceId));
       dispatch(
         editorActions.setNodeDataPanelTabSelected(DataPanelTabKey.Input),
       );
@@ -76,7 +76,7 @@ describe("BrickDataPanel", () => {
     expect(reportEventMock).toHaveBeenCalledOnce();
     expect(reportEventMock).toHaveBeenCalledWith(Events.DATA_PANEL_TAB_VIEW, {
       tabName: DataPanelTabKey.Input,
-      brickId: formState.modComponent.brickPipeline[1]!.id,
+      brickId: formState.modComponent.brickPipeline[1].id,
       modId: undefined,
     });
 
@@ -95,7 +95,7 @@ describe("BrickDataPanel", () => {
     expect(reportEventMock).toHaveBeenCalledOnce();
     expect(reportEventMock).toHaveBeenCalledWith(Events.DATA_PANEL_TAB_VIEW, {
       tabName: DataPanelTabKey.Comments,
-      brickId: formState.modComponent.brickPipeline[1]!.id,
+      brickId: formState.modComponent.brickPipeline[1].id,
       modId: undefined,
     });
   });

diff --git a/src/pageEditor/tabs/editTab/dataPanel/StarterBrickDataPanel.test.tsx b/src/pageEditor/tabs/editTab/dataPanel/StarterBrickDataPanel.test.tsx
@@ -28,7 +28,7 @@ describe("StarterBrickDataPanel", () => {
   it("renders with form state and trace data", async () => {
     const { formState, records } = formStateWithTraceDataFactory();
     const modComponentId = formState.uuid;
-    const { instanceId } = formState.modComponent.brickPipeline[0]!;
+    const { instanceId } = formState.modComponent.brickPipeline[0];
     const { asFragment } = render(<StarterBrickDataPanel />, {
       initialValues: formState,
       setupRedux(dispatch) {
@@ -40,7 +40,7 @@ describe("StarterBrickDataPanel", () => {
             records,
           }),
         );
-        dispatch(editorActions.setActiveNodeId(instanceId!));
+        dispatch(editorActions.setActiveNodeId(instanceId));
       },
     });
     await waitForEffect();

diff --git a/src/pageEditor/tabs/editTab/dataPanel/tabs/CommentsTab.test.tsx b/src/pageEditor/tabs/editTab/dataPanel/tabs/CommentsTab.test.tsx
@@ -59,7 +59,7 @@ const renderCommentsTab = (formState = formStateWithComments) => {
         dispatch(editorActions.setActiveModComponentId(formState.uuid));
         dispatch(
           editorActions.setActiveNodeId(
-            formState.modComponent.brickPipeline[0]!.instanceId!,
+            formState.modComponent.brickPipeline[0].instanceId,
           ),
         );
       },
@@ -88,7 +88,7 @@ describe("CommentsTab", () => {
     // Trigger onBlur event for the textarea
     await userEvent.keyboard("{tab}");
     const expectedBrickId =
-      formStateWithNoComments.modComponent.brickPipeline[0]!.id;
+      formStateWithNoComments.modComponent.brickPipeline[0].id;
 
     expect(reportEventMock).toHaveBeenCalledWith(Events.BRICK_COMMENTS_UPDATE, {
       commentsLength: newComments.length,
@@ -110,12 +110,12 @@ describe("CommentsTab", () => {
     // Trigger onBlur event for the textarea
     await userEvent.keyboard("{tab}");
     const expectedBrickId =
-      formStateWithComments.modComponent.brickPipeline[0]!.id;
+      formStateWithComments.modComponent.brickPipeline[0].id;
 
     expect(reportEventMock).toHaveBeenCalledWith(Events.BRICK_COMMENTS_UPDATE, {
       commentsLength: expectedComments.length,
       brickId: expectedBrickId,
-      modId: formStateWithComments.modMetadata!.id,
+      modId: formStateWithComments.modMetadata.id,
     });
   });
 });
diff --git a/src/pageEditor/tabs/editTab/editHelpers.test.ts b/src/pageEditor/tabs/editTab/editHelpers.test.ts
@@ -39,8 +39,8 @@ describe("getPipelineMap", () => {
     expect(Object.keys(pipelineMap)).toHaveLength(2);
 
     const firstBlock = pipeline[0];
-    expect(pipelineMap[firstBlock!.instanceId!]).toEqual({
-      blockId: firstBlock!.id,
+    expect(pipelineMap[firstBlock.instanceId]).toEqual({
+      blockId: firstBlock.id,
       path: `${PIPELINE_BRICKS_FIELD_NAME}.0`,
       blockConfig: firstBlock,
       index: 0,
@@ -50,8 +50,8 @@ describe("getPipelineMap", () => {
     });
 
     const secondBlock = pipeline[1];
-    expect(pipelineMap[secondBlock!.instanceId!]).toEqual({
-      blockId: secondBlock!.id,
+    expect(pipelineMap[secondBlock.instanceId]).toEqual({
+      blockId: secondBlock.id,
       path: `${PIPELINE_BRICKS_FIELD_NAME}.1`,
       blockConfig: secondBlock,
       index: 1,
@@ -78,8 +78,8 @@ describe("getPipelineMap", () => {
 
     const subPipelineFirstBlock = subPipeline[0];
 
-    expect(pipelineMap[subPipelineFirstBlock!.instanceId!]).toEqual({
-      blockId: subPipelineFirstBlock!.id,
+    expect(pipelineMap[subPipelineFirstBlock.instanceId]).toEqual({
+      blockId: subPipelineFirstBlock.id,
       path: `${PIPELINE_BRICKS_FIELD_NAME}.0.config.body.__value__.0`,
       blockConfig: subPipelineFirstBlock,
       index: 0,
@@ -89,8 +89,8 @@ describe("getPipelineMap", () => {
     });
 
     const subPipelineSecondBlock = subPipeline[1];
-    expect(pipelineMap[subPipelineSecondBlock!.instanceId!]).toEqual({
-      blockId: subPipelineSecondBlock!.id,
+    expect(pipelineMap[subPipelineSecondBlock.instanceId]).toEqual({
+      blockId: subPipelineSecondBlock.id,
       path: `${PIPELINE_BRICKS_FIELD_NAME}.0.config.body.__value__.1`,
       blockConfig: subPipelineSecondBlock,
       index: 1,
@@ -106,7 +106,7 @@ describe("getPipelineMap", () => {
     (buttonElement.config.onClick as PipelineExpression).__value__ =
       subPipeline;
     const containerElement = createNewDocumentBuilderElement("container");
-    containerElement.children![0]!.children![0]!.children!.push(buttonElement);
+    containerElement.children[0].children[0].children.push(buttonElement);
     const documentBrick = brickConfigFactory({
       id: DocumentRenderer.BRICK_ID,
       config: {
@@ -120,8 +120,8 @@ describe("getPipelineMap", () => {
     expect(Object.keys(pipelineMap)).toHaveLength(3);
 
     const subPipelineFirstBlock = subPipeline[0];
-    expect(pipelineMap[subPipelineFirstBlock!.instanceId!]).toEqual({
-      blockId: subPipelineFirstBlock!.id,
+    expect(pipelineMap[subPipelineFirstBlock.instanceId]).toEqual({
+      blockId: subPipelineFirstBlock.id,
       path: `${PIPELINE_BRICKS_FIELD_NAME}.0.config.body.0.children.0.children.0.children.0.config.onClick.__value__.0`,
       blockConfig: subPipelineFirstBlock,
       index: 0,
@@ -131,8 +131,8 @@ describe("getPipelineMap", () => {
     });
 
     const subPipelineSecondBlock = subPipeline[1];
-    expect(pipelineMap[subPipelineSecondBlock!.instanceId!]).toEqual({
-      blockId: subPipelineSecondBlock!.id,
+    expect(pipelineMap[subPipelineSecondBlock.instanceId]).toEqual({
+      blockId: subPipelineSecondBlock.id,
       path: `${PIPELINE_BRICKS_FIELD_NAME}.0.config.body.0.children.0.children.0.children.0.config.onClick.__value__.1`,
       blockConfig: subPipelineSecondBlock,
       index: 1,

diff --git a/src/pageEditor/tabs/editTab/editorNodeConfigPanel/CommentsPreview.test.tsx b/src/pageEditor/tabs/editTab/editorNodeConfigPanel/CommentsPreview.test.tsx
@@ -32,7 +32,7 @@ const renderCommentsPreview = (comments: string) => {
       dispatch(actions.setActiveModComponentId(formState.uuid));
       dispatch(
         actions.setActiveNodeId(
-          formState.modComponent.brickPipeline[0]!.instanceId!,
+          formState.modComponent.brickPipeline[0].instanceId,
         ),
       );
       dispatch(actions.setNodeDataPanelTabSelected(DataPanelTabKey.Input));

diff --git a/src/pageEditor/tabs/effect/BrickConfiguration.test.tsx b/src/pageEditor/tabs/effect/BrickConfiguration.test.tsx
@@ -63,7 +63,7 @@ function renderBrickConfiguration(
       dispatch(actions.setActiveModComponentId(initialValues.uuid));
       dispatch(
         actions.setActiveNodeId(
-          initialValues.modComponent.brickPipeline[0]!.instanceId!,
+          initialValues.modComponent.brickPipeline[0].instanceId,
         ),
       );
     },

diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json
@@ -4,13 +4,6 @@
     "strictNullChecks": true
   },
   "files": [
-    "./pageEditor/store/editor/editorSliceHelpers.test.ts",
-    "./pageEditor/tabs/editTab/dataPanel/BrickDataPanel.test.tsx",
-    "./pageEditor/tabs/editTab/dataPanel/StarterBrickDataPanel.test.tsx",
-    "./pageEditor/tabs/editTab/dataPanel/tabs/CommentsTab.test.tsx",
-    "./pageEditor/tabs/editTab/editHelpers.test.ts",
-    "./pageEditor/tabs/editTab/editorNodeConfigPanel/CommentsPreview.test.tsx",
-    "./pageEditor/tabs/effect/BrickConfiguration.test.tsx",
     "./pageEditor/tabs/trigger/TriggerConfiguration.test.tsx",
     "./registry/packageRegistry.test.ts",
     "./runtime/pipelineTests/validateInput.test.ts",