Skip to content

Commit

Permalink
more flakiness fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
fungairino committed Oct 10, 2024
1 parent 05f4df2 commit b48bb91
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
8 changes: 6 additions & 2 deletions end-to-end-tests/pageObjects/extensionConsole/modsPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ export class ModTableItem extends BasePageObject {
// Wrapped in `toPass` due to flakiness with dropdown visibility due to component remounting
await expect(async () => {
if (!(await this.dropdownMenu.isVisible())) {
await this.dropdownButton.click();
await this.dropdownButton.click({
timeout: 5000,
});
}

try {
Expand All @@ -46,7 +48,9 @@ export class ModTableItem extends BasePageObject {
throw error;
}

await this.getByRole("menuitem", { name: actionName }).click();
await this.getByRole("menuitem", { name: actionName }).click({
timeout: 5000,
});
}).toPass({ timeout: DEFAULT_TIMEOUT });
}
}
Expand Down
5 changes: 5 additions & 0 deletions end-to-end-tests/tests/pageEditor/addStarterBrick.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,11 @@ test("Add starter brick to mod", async ({
verifyModDefinitionSnapshot,
chromiumChannel,
}) => {
test.slow(
true,
"Longer test due to verifying each starter brick definition in one user flow",
);

await page.goto("/");
const pageEditorPage = await newPageEditorPage(page.url());
const brickPipeline = pageEditorPage.brickActionsPanel.bricks;
Expand Down

0 comments on commit b48bb91

Please sign in to comment.