Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable import cycle detection on CI #6778

Closed
twschiller opened this issue Oct 31, 2023 · 0 comments · Fixed by #6857
Closed

Enable import cycle detection on CI #6778

twschiller opened this issue Oct 31, 2023 · 0 comments · Fixed by #6857
Labels
developer experience

Comments

@twschiller
Copy link
Contributor

User Story

As a PixieBrix developer, I want CI to check for circular dependencies, so that we don't accidentally introduce error-prone/hard to debug circular dependencies in the future

Motivation

Acceptance Criteria

  • CI fails if there are circular dependencies in the code
@twschiller twschiller changed the title Enable cycle detection on CI Enable import cycle detection on CI Nov 6, 2023
@fregante fregante mentioned this issue Nov 11, 2023
Merged
1 task
fregante added a commit that referenced this issue Nov 14, 2023
@fregante
#6778: Fail CI on dependency cycles and remove madge (#6857)
6823904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#6778: Fail CI on dependency cycles and remove madge pixiebrix/pixiebrix-extension
1 participant
@twschiller