Cleanup eslint config

[fregante]

Setup for #536
Includes parts of #513

This PR ensures that the lint script actually runs without errors.

Before moving onto adding further plugins, I think it's best to fix existing errors first.

[fregante]

Codacy only tracks changes, but not existing files. I added this CI job to ensure that all files are affected by new rules.

Possible improvements:

• Run this job only if the lockfile or eslint config has changed

[fregante]

The workflow would be this, if interested, but I think it's best to just leave it running at all times. It costs nothing and it already passes thanks to this PR 🎉

lint.yml

name: Lint

on:
  push:
    branches:
      - "*"
    path:
      - .eslintrc
      - package-lock.json

jobs:
  lint:
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-node@v1
        with:
          node-version: "14.x"
      - uses: bahmutov/npm-install@v1

      # Run eslint without GitHub Actions annotations
      # https://stackoverflow.com/a/65964721/288906
      - name: npm run lint
        run: |
          echo "::remove-matcher owner=eslint-compact::"
          echo "::remove-matcher owner=eslint-stylish::"
          npm run lint

[fregante]

From the docs:

asset/source exports the source code of the asset. Previously achievable by using raw-loader.

From a quick check of the dist/options.js, it seems to work, but a raw string is exported instead of a function. Can you run this code to ensure it still works?

Before

After

[twschiller]

@fregante You can test this by 1) going to the workshop, 2) clicking create new brick, and 3) selecting a template from the dropdown

See documentation for more information on accessing: https://docs.pixiebrix.com/developer-guide/workshop-basics#202afa4a0c0b4c449031d30540ba9a5d

[fregante]

Thanks! With your steps I'll find my way around the code base over time. As you said going from the UI to the code is as easy as searching a string, but code -> UI takes a bit more time.

Anyway, tested and it works 👍

[twschiller]

@fregante see comment on how to test.

Also, I merged in the prettier PR you made, so you might need to re-run on these files? Do we need to fix the prettier configuration in pre-commit: http://github.com/pixiebrix/pixiebrix-extension/blob/7e46cde8f20cc265af7668d1d40c98a2bab9160a/.pre-commit-config.yaml#L13-L13?

[fregante]

Prettier run, PR ready to merge.