Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7670: Ensure stylesheets are removed in IsolatedComponent #8213

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

fregante
Copy link
Contributor

What does this PR do?

I mistakenly broke the stylesheet listener in one of the last commits there. This reverts the commit.

Checklist

  • Add jest or playwright tests and/or storybook stories
  • Designate a primary reviewer: @grahamlangford

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.43%. Comparing base (5a4565c) to head (3695681).
Report is 4 commits behind head on main.

❗ Current head 3695681 differs from pull request most recent head 8a8cc93. Consider uploading reports for the commit 8a8cc93 to get more accurate results

Files Patch % Lines
src/components/IsolatedComponent.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8213   +/-   ##
=======================================
  Coverage   73.42%   73.43%           
=======================================
  Files        1319     1319           
  Lines       40825    40825           
  Branches     7578     7578           
=======================================
+ Hits        29976    29978    +2     
+ Misses      10849    10847    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fregante fregante changed the title #7670: Ensure stylesheets are removed in IsolatedComponent #7670: Ensure stylesheets are removed in IsolatedComponent Apr 10, 2024
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

Co-authored-by: Graham Langford <30706330+grahamlangford@users.noreply.github.com>
@twschiller twschiller enabled auto-merge (squash) April 10, 2024 20:34
@twschiller twschiller added this to the 1.8.13 milestone Apr 10, 2024
@twschiller twschiller merged commit 6e2f02e into main Apr 10, 2024
18 of 19 checks passed
@twschiller twschiller deleted the F/bug/isolated-components branch April 10, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants