Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8636: fix search/insert for variable popover using optional chaining #8637

Merged
merged 5 commits into from
Jun 17, 2024
Merged

#8636: fix search/insert for variable popover using optional chaining #8637

merged 5 commits into from
Jun 17, 2024

Commits on Jun 17, 2024

  1. 8636: fix search/insert for variable popover using optional chaining 

    8636: extract getFullVariableName

8636: handle optional chaining corner cases

Clarify method comment
    @twschiller
    twschiller committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    3d2f0d6 View commit details
    Browse the repository at this point in the history

  2. Add test bracket corner case

    @twschiller
    twschiller committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a5c348f View commit details
    Browse the repository at this point in the history

  3. Address PR comments

    @twschiller
    twschiller committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    becb336 View commit details
    Browse the repository at this point in the history

  4. Try fixing lint

    @twschiller
    twschiller committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    4962786 View commit details
    Browse the repository at this point in the history

  5. Clarify todo comment

    @twschiller
    twschiller committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    41afd27 View commit details
    Browse the repository at this point in the history