Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8739 Package standalone mods on save - Slice 3 #8796

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

BLoe
Copy link
Contributor

@BLoe BLoe commented Jul 11, 2024

What does this PR do?

For more information on our expectations for the PR process, see the
code review principles doc

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.18%. Comparing base (8318d74) to head (f993673).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8796      +/-   ##
==========================================
- Coverage   74.24%   74.18%   -0.07%     
==========================================
  Files        1332     1332              
  Lines       40817    40940     +123     
  Branches     7634     7665      +31     
==========================================
+ Hits        30306    30371      +65     
- Misses      10511    10569      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Playwright test results

passed  83 passed
flaky  1 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  88 tests across 31 suites
duration  13 minutes, 39 seconds
commit  f993673

Flaky tests

chromeSetup › setup/affiliated.setup.ts › authenticate with affiliated user

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
edge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@@ -486,7 +486,6 @@ export const {
useGetStandaloneModDefinitionQuery,
useGetAllStandaloneModDefinitionsQuery,
useDeleteStandaloneModDefinitionMutation,
useSaveStandaloneModDefinitionMutation,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@BLoe BLoe merged commit d4dce5d into main Jul 11, 2024
27 checks passed
@BLoe BLoe deleted the feature/8739-save-components-as-mods-slice3 branch July 11, 2024 13:48
@grahamlangford grahamlangford added this to the 2.0.5 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slice 3: Remove dead code for saving standalone mod components
3 participants