Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slice 4: Use ModInstance type in mods updater #9192

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Slice 4: Use ModInstance type in mods updater #9192

merged 1 commit into from
Oct 8, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Sep 22, 2024 •
edited
Loading

What does this PR do?

Future Work

Continue gradual work toward eliminating mod components on the slice boundary:

  • Replace remaining occurrences of selectActivatedModComponents, selectGetModComponentsForMod, selectModHasAnyActivatedModComponents, etc.
  • Replace component slice actions taking mod components with actions taking mod instances

For more information on our expectations for the PR process, see the
code review principles doc

@twschiller twschiller changed the base branch from main to feature/devex-mod-instance-mods-screen September 22, 2024 23:53
twschiller
twschiller commented Sep 22, 2024
View reviewed changes
src/background/modUpdater.test.ts
@@ -143,42 +143,6 @@ describe("getActivatedMarketplaceModVersions function", () => {
},
]);
});

it("reports error if multiple mod component versions activated for same mod", async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't happen anymore - ModInstance only has a single version

twschiller
twschiller commented Sep 22, 2024
View reviewed changes
src/background/utils/deactivateMod.test.ts
);

expect(nextModComponentState.activatedModComponents).toHaveLength(1);
});

it("should do nothing if mod id does not have any activated mod components", async () => {
Copy link
Contributor Author

@twschiller twschiller Sep 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having it do nothing, the caller is now responsible for skipping. (The caller must produce a ModInstance value)

@twschiller twschiller added developer experience do not merge Merging of this PR is blocked by another one 30% time labels Sep 22, 2024
@twschiller twschiller self-assigned this Sep 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Playwright test results

passed  131 passed
flaky  7 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  142 tests across 46 suites
duration  33 minutes, 18 seconds
commit  85e85cf
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/extensionConsole/activation.spec.ts › can activate a mod with a database
chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add new mod with different starter brick components
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
chrome › tests/pageEditor/brickActions.spec.ts › brick actions panel behavior
msedge › tests/pageEditor/brickConfiguration.spec.ts › brick configuration
chrome › tests/telemetry/errors.spec.ts › can report an indexdb error to telemetry service

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@twschiller twschiller marked this pull request as draft September 23, 2024 00:24
@twschiller twschiller mentioned this pull request Sep 23, 2024
Merged
@twschiller twschiller force-pushed the feature/devex-mod-instance-updater branch from eefe60b to 56f447b Compare September 23, 2024 02:23
@twschiller twschiller marked this pull request as ready for review September 23, 2024 02:23
@twschiller twschiller changed the title Use ModInstance type in Mods Update (4/3) Use ModInstance type in mods updater (4/3) Sep 23, 2024
@twschiller twschiller changed the title Use ModInstance type in mods updater (4/3) Slice 4: Use ModInstance type in mods updater Sep 24, 2024
@twschiller twschiller added this to the 2.1.4 milestone Oct 7, 2024
@twschiller twschiller force-pushed the feature/devex-mod-instance-mods-screen branch 3 times, most recently from 15e7512 to 62357a5 Compare October 8, 2024 02:23
@twschiller twschiller force-pushed the feature/devex-mod-instance-updater branch from 56f447b to 9aa6236 Compare October 8, 2024 02:43
@twschiller twschiller force-pushed the feature/devex-mod-instance-mods-screen branch from 35d7f04 to edf21de Compare October 8, 2024 13:32
Base automatically changed from feature/devex-mod-instance-mods-screen to main October 8, 2024 13:57
@twschiller
Use mod instance in marketplace mod updater
85e85cf 
Remove test debugging statement
@twschiller twschiller force-pushed the feature/devex-mod-instance-updater branch from 9aa6236 to 85e85cf Compare October 8, 2024 13:57
@twschiller twschiller removed the do not merge Merging of this PR is blocked by another one label Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller enabled auto-merge (squash) October 8, 2024 14:04
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.10%. Comparing base (8318d74) to head (85e85cf).
Report is 349 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9192      +/-   ##
==========================================
+ Coverage   74.24%   75.10%   +0.85%     
==========================================
  Files        1332     1370      +38     
  Lines       40817    42295    +1478     
  Branches     7634     7888     +254     
==========================================
+ Hits        30306    31766    +1460     
- Misses      10511    10529      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twschiller twschiller merged commit 0707b0a into main Oct 8, 2024
23 checks passed
@twschiller twschiller deleted the feature/devex-mod-instance-updater branch October 8, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamlangford grahamlangford grahamlangford approved these changes

Assignees

@twschiller twschiller

Labels
30% time developer experience
Projects
None yet
Milestone
2.1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@twschiller @grahamlangford