Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9198: properly serialize axios errors in report error, and skip non mod logs for idb #9201

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

fungairino
Copy link
Collaborator

@fungairino fungairino commented Sep 24, 2024

What does this PR do?

@fungairino fungairino self-assigned this Sep 24, 2024
@fungairino fungairino linked an issue Sep 24, 2024 that may be closed by this pull request
@twschiller twschiller added the bug Something isn't working label Sep 24, 2024
@twschiller twschiller added this to the 2.1.3 milestone Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.82%. Comparing base (8318d74) to head (36a7c5e).
Report is 318 commits behind head on main.

Files with missing lines Patch % Lines
src/telemetry/logging.ts 20.00% 4 Missing ⚠️
src/data/service/requestErrorUtils.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9201      +/-   ##
==========================================
+ Coverage   74.24%   74.82%   +0.57%     
==========================================
  Files        1332     1365      +33     
  Lines       40817    42050    +1233     
  Branches     7634     7852     +218     
==========================================
+ Hits        30306    31462    +1156     
- Misses      10511    10588      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fungairino fungairino changed the title properly serialize axios errors in report error, and skip non mod logs for idb #9198: properly serialize axios errors in report error, and skip non mod logs for idb Sep 24, 2024
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

Copy link

github-actions bot commented Sep 24, 2024

Playwright test results

passed  128 passed
flaky  6 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  138 tests across 45 suites
duration  28 minutes, 12 seconds
commit  36a7c5e
info  For more information on how to debug and view this report, see our readme

Flaky tests

msedge-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user
chrome › tests/modLifecycle.spec.ts › create, run, package, and update mod
chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration
msedge › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@fungairino fungairino enabled auto-merge (squash) September 24, 2024 21:41
@fungairino fungairino merged commit 3ac5e32 into main Sep 24, 2024
20 checks passed
@fungairino fungairino deleted the 9198-failed-to-execute-add-on-idbobjectstore branch September 24, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to execute 'add' on 'IDBObjectStore'
3 participants