#9209: eliminate new standalone mod components from Page Editor UI via "unsaved" mods

[BLoe]

What does this PR do?

• Closes Implement "unsaved mods" with @inner registry IDs - Slice 2 #9209

Remaining Work

• Determine whether or not to skip component count tests: #9209: eliminate new standalone mod components from Page Editor UI via "unsaved" mods #9219 (comment)

Product/Design micro-decisions

cc @Pashaminkovsky

• When a starter brick is picked from the menu and a new, "unsaved" mod is created, it will default to the name/label "New Mod," with a number added, counting up from 1, to avoid duplicates. So, e.g. "New Mod," "New Mod 1," "New Mod 2," etc.
• A mod component cannot be deleted or moved to another mod if it is the only component in the mod

Future Work

• Remaining slices: https://www.notion.so/pixiebrix/Re-Slicing-Eliminate-Standalone-mods-from-UI-694e4c85e61441809e14aec18f6b6109?pvs=4
• If the "Save new mod" modal is displayed over the mod metadata form, there are elements with duplicate ids on the page. E.g., id=description field is contained within both forms: CreateModModal causes multiple DOM elements with same id #9238
• There are now 5 save hooks/approaches in the Page Editor 🤷, increasing risk for handling corner-cases inconsistently. Getting items to a single representation will help consolidate the logic
  • useSaveMod
  • useCreateModFromMod
  • useCreateModFromUnsavedMod
  • useCreateModFromModComponent
  • useUpsertModComponentFormState

For more information on our expectations for the PR process, see the
code review principles doc

[codecov]

Codecov Report

Attention: Patch coverage is 55.22388% with 120 lines in your changes missing coverage. Please review.

Project coverage is 74.75%. Comparing base (8318d74) to head (38f890a).
Report is 339 commits behind head on main.

Files with missing lines	Patch %	Lines
src/pageEditor/hooks/useCreateModFromUnsavedMod.ts	29.16%	51 Missing ⚠️
...geEditor/modListingPanel/modals/CreateModModal.tsx	8.82%	31 Missing ⚠️
src/pageEditor/hooks/useAddNewModComponent.ts	26.08%	17 Missing ⚠️
src/pageEditor/hooks/useSaveMod.ts	82.14%	10 Missing ⚠️
src/pageEditor/store/editor/editorSelectors.ts	55.55%	4 Missing ⚠️
src/pageEditor/hooks/useCreateModFromMod.ts	85.71%	3 Missing ⚠️
.../pageEditor/tabs/modMetadata/ModMetadataEditor.tsx	66.66%	3 Missing ⚠️
src/pageEditor/modListingPanel/ModComponents.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9219      +/-   ##
==========================================
+ Coverage   74.24%   74.75%   +0.51%     
==========================================
  Files        1332     1368      +36     
  Lines       40817    42356    +1539     
  Branches     7634     7914     +280     
==========================================
+ Hits        30306    31665    +1359     
- Misses      10511    10691     +180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Playwright test results

 131 passed
 3 flaky
 4 skipped

Details

 Open report ↗︎
 138 tests across 45 suites
 11 minutes, 42 seconds
 38f890a
 For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/runtime/modVariables/variableSync.spec.ts › Mod Variable Sync › session variable cross-tab sync

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

[grahamlangford]

Ideally we should either validate that we do need these now or delete them. Otherwise, I think they're just going to end up being left skipped

[BLoe]

I'll update the comment, I meant that I think I need to finish the entire project and then see if it still makes sense to have this test and update it to work, or if we should delete it.

[twschiller]

Those tests are no longer relevant because the hook doesn't call the methods because there's no original/"source" mod