Require version on ModDefinition.metadata

[twschiller]

What does this PR do?

• Strengthen types on ModDefinition.metadata and ModMetadata to require version
• In practice, version is always defined (b/c it must be defined to save the mod). It's just not required on the base Metadata type due to JS-defined bricks having their version determined at runtime

Future

• Strengthen Metadata type to required version: Strengthen Metadata type to require version #9265

For more information on our expectations for the PR process, see the
code review principles doc

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.09%. Comparing base (8318d74) to head (5697465).
Report is 357 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9264      +/-   ##
==========================================
+ Coverage   74.24%   75.09%   +0.84%     
==========================================
  Files        1332     1369      +37     
  Lines       40817    42267    +1450     
  Branches     7634     7882     +248     
==========================================
+ Hits        30306    31740    +1434     
- Misses      10511    10527      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Playwright test results

 134 passed
 4 flaky
 4 skipped

Details

 Open report ↗︎
 142 tests across 46 suites
 13 minutes, 40 seconds
 5697465
 For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/modLifecycle.spec.ts › create, run, package, and update mod
chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
chrome › tests/regressions/hideModalsOnPageEditorRefresh.spec.ts › should hide add brick modal when Page Editor refreshes

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

[fungairino]

I like the incremental approach of just tackling ModDefinition.metadata first. Nice job!

[github-actions]

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.