Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ModComponentActionMenu remove unnecessary props #9270

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Oct 10, 2024

What does this PR do?

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller
Copy link
Contributor

@mnholtz you'll need to update deleted snapshots

@twschiller twschiller added this to the 2.1.5 milestone Oct 10, 2024
Copy link

github-actions bot commented Oct 10, 2024

Playwright test results

passed  137 passed
flaky  3 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  142 tests across 46 suites
duration  13 minutes, 50 seconds
commit  855b609
info  For more information on how to debug and view this report, see our readme

Flaky tests

msedge-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user
msedge › tests/modLifecycle.spec.ts › create, run, package, and update mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add new mod with different starter brick components

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants