Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobDistdir: check for glob usage with DISTDIR #610

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

arthurzam
Copy link
Member

This time I decided to try to implement using tree-sitter query language. It is faster than in python scan, which is nice.

$ pkgcheck scan -c GlobCheck
games-strategy/homm2-gold-gog
  GlobDistdir: version 1.1.2.1.33438: line 40: unsafe filename expansion used with DISTDIR: "${DISTDIR}"/setup_heroes*.exe

media-gfx/darktable
  GlobDistdir: version 4.2.1: line 174: unsafe filename expansion used with DISTDIR: "${DISTDIR}"/${PN}-usermanual-${DOC_PV}.*.pdf
  GlobDistdir: version 4.4.1: line 171: unsafe filename expansion used with DISTDIR: "${DISTDIR}"/${PN}-usermanual-${DOC_PV}.*.pdf
  GlobDistdir: version 4.4.2: line 171: unsafe filename expansion used with DISTDIR: "${DISTDIR}"/${PN}-usermanual-${DOC_PV}.*.pdf

Resolves: #605

@arthurzam arthurzam requested a review from mgorny August 3, 2023 19:26
@arthurzam
Copy link
Member Author

@mgorny ping :)

Copy link
Contributor

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue about the magic but if it works, then that works for me ;-).

Resolves: pkgcore#605
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@gentoo-bot gentoo-bot merged commit 18e21c8 into pkgcore:master Aug 30, 2023
8 checks passed
@arthurzam arthurzam deleted the check-glob-distdir branch August 30, 2023 15:46
@gentoo-bot gentoo-bot temporarily deployed to github-pages August 30, 2023 15:47 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Check]: Use of globs on DISTDIR
3 participants