Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve multimodal publishing with OJS #7739

Closed
3 tasks done
asmecher opened this issue Mar 4, 2022 · 4 comments
Closed
3 tasks done

Improve multimodal publishing with OJS #7739

asmecher opened this issue Mar 4, 2022 · 4 comments
Assignees
@asmecher
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone
3.3.0-11

Comments

@asmecher
Copy link
Member

asmecher commented Mar 4, 2022 •
edited
Loading

This is a catch-all issue for several minor improvements related to multimodal publishing with OJS.

  • Disable text indexing of JS assets that are uploaded as dependent files to articles. (Already merged to stable-3_3_0 and main.)
  • Add support for url(some-file.woff)-style URLs to OJS's URL rewriting set for HTML galleys; this format is used in CSS.
  • Add original filenames as extra PATH_INFO pieces to rewritten URLs in HTML galleys. Some tools (e.g. timeline.js) depend on file extensions to detect different media types.
@asmecher asmecher added this to the 3.3.0-10 milestone Mar 4, 2022
@asmecher asmecher self-assigned this Mar 4, 2022
asmecher added a commit that referenced this issue Mar 5, 2022
@asmecher
#7739 Add hint for Javascript files
ea6358a
asmecher added a commit that referenced this issue Mar 5, 2022
@asmecher
#7739 Add hint for Javascript files
d664683
asmecher added a commit to asmecher/ojs that referenced this issue Mar 5, 2022
@asmecher
pkp/pkp-lib#7739 Add CSS url support; add original filenames to media…
a39dfb6 
… URLs
@asmecher
Copy link
Member Author

asmecher commented Mar 5, 2022

PR for OJS stable-3_3_0: pkp/ojs#3317

@asmecher
Copy link
Member Author

asmecher commented Mar 5, 2022

@NateWr, could you take a look at the PR? Happy to provide more context on the changes.

@NateWr
Copy link
Contributor

NateWr commented Mar 7, 2022

Looks good to me. I added one comment. Do you plan to roll this out to OMP/OPS?

@NateWr NateWr added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Mar 7, 2022
asmecher added a commit to asmecher/ojs that referenced this issue May 20, 2022
@asmecher
pkp/pkp-lib#7739 Add CSS url support; add original filenames to media…
9ce9358 
… URLs
asmecher added a commit to pkp/ojs that referenced this issue May 20, 2022
@asmecher
Merge pull request #3317 from asmecher/i7739-fix
6ff3947 
pkp/pkp-lib#7739 Add CSS url support; add original filenames to media URLs
asmecher added a commit to pkp/ojs that referenced this issue May 20, 2022
@asmecher
pkp/pkp-lib#7739 Add CSS URL support; add original filenames to media…
9dffe0c 
… URLs
@asmecher
Copy link
Member Author

Merged and ported to main, thanks, @NateWr!

Do you plan to roll this out to OMP/OPS?

There is no HTML galley plugin for OMP or OPS yet, but when it gets ported there, these changes will be included too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asmecher asmecher

Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
None yet
Milestone
3.3.0-11
Development

No branches or pull requests
2 participants
@asmecher @NateWr