Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to edit rich text fields (TinyMCE) such as submission title and abstract #8901

Closed
saalam opened this issue Apr 8, 2023 · 7 comments
Assignees
Labels
Bug:3:Critical A bug that prevents a substantial minority of users from using the software.

Comments

@saalam
Copy link
Contributor

saalam commented Apr 8, 2023

Describe the bug
Title Field is locked and can't type anything when I try to insert title
To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Submissions'
  2. Click on 'New Submission'
  3. Scroll down to 'Title'
  4. See error

What application are you using?
OJS version 3.4.0 PHP version 8.0.28

Additional information
image

@saalam saalam changed the title Title Box blocked It is not possible to write and edit the title field Apr 8, 2023
@Vitaliy-1
Copy link
Collaborator

Hi @saalam,

Are there any related errors in the browser console?

@NateWr
Copy link
Contributor

NateWr commented Apr 10, 2023

Yes, I strongly suspect this is a problem with the TinyMCE editor. It could be the built JavaScript in the release package or something. The error will most likely be detectable through an error in the browser's console.

There are several related issues. I'm going to keep this and close the others.

@NateWr NateWr added this to the 3.4.0rc2 External Testing milestone Apr 10, 2023
@NateWr NateWr added the Bug:3:Critical A bug that prevents a substantial minority of users from using the software. label Apr 10, 2023
@NateWr NateWr changed the title It is not possible to write and edit the title field Not possible to edit rich text fields (TinyMCE) such as submission title and abstract Apr 10, 2023
@NateWr
Copy link
Contributor

NateWr commented Apr 10, 2023

@saalam (and anyone else experiencing this issue) can you also post details about your OS (Win/Mac/Linux) and browser (Chrome/Firefox/Edge)?

@saalam
Copy link
Contributor Author

saalam commented Apr 10, 2023

Hi @Vitaliy-1 To be honest I went through only PHP error log and I saw nothing about it in the error log file.
Hi @NateWr Regarding your question I'm using Windows OS with Chrome Browser.

NateWr added a commit to NateWr/pkp-lib that referenced this issue Apr 10, 2023
NateWr added a commit to NateWr/ojs that referenced this issue Apr 10, 2023
NateWr added a commit to NateWr/omp that referenced this issue Apr 10, 2023
NateWr added a commit to NateWr/ops that referenced this issue Apr 10, 2023
@NateWr
Copy link
Contributor

NateWr commented Apr 10, 2023

Looks like this is a build error. @asmecher I didn't realize that lib/ui-library was excluded from the release package. With the latest updates to TinyMCE, I chose to house some files in lib/ui-library/public/styles/tinymce/ to prevent duplication.

In hindsight, the decision to exclude lib/ui-library from the release package seems more sensible. In the PRs below, I've added a step to webpack so that it will copy the files from the tinymce directory in ui-library into lib/pkp/styles/tinymce. Then the applications load them from there, rather than the UI Library.

This fixed the problem for me, but can you test a release package?

One last decision to be made: these files will be copied whenever someone runs npm run dev or npm run build. In my view, these are build files, so we shouldn't commit them. That way they are always built from the correct branch of lib/ui-library. If you're happy with that (rather than committing them), let me know and I'll add this directory to the .gitignore file for each app.

PRs:
#8904
pkp/ojs#3871
pkp/omp#1388
pkp/ops#512

@asmecher
Copy link
Member

@NateWr, those are sensible decisions. If you're ready to merge these, please go ahead; I'll build a new RC3 package and test it manually before making it available.

NateWr added a commit that referenced this issue Apr 12, 2023
#8901 Fix missing TinyMCE files in release package
NateWr added a commit to pkp/ojs that referenced this issue Apr 12, 2023
pkp/pkp-lib#8901 Fix missing TinyMCE files in release package
NateWr added a commit to pkp/omp that referenced this issue Apr 12, 2023
pkp/pkp-lib#8901 Fix missing TinyMCE files in release package
NateWr added a commit to pkp/ops that referenced this issue Apr 12, 2023
pkp/pkp-lib#8901 Fix missing TinyMCE files in release package
@NateWr
Copy link
Contributor

NateWr commented Apr 12, 2023

Great! Merged those and added the directory to .gitignore in pkp-lib.

@NateWr NateWr closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:3:Critical A bug that prevents a substantial minority of users from using the software.
Projects
None yet
Development

No branches or pull requests

5 participants