3.8 python fails, includes src layout change #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
latest travis build confirms its a python 3.8 issue |
AndrewAnnex
changed the title
|
I don't have a good notion for how to fix this yet and won't be able to dig into it further but @rbeyer and @michaelaye feel free to commit to my branch to patch it up (that is if you want to switch to src layout, which wasn't the issue but doesn't actually hurt anything as far as I can tell) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
locally I confirmed running the tests in python 3.7 everything was fine but 3.8 which I was using in a pycharm conda env was failing even outside of pycharm. switching to src layout shouldn't really fix anything but is probably worth doing anyways. if I am correct, the 3.8 test will fail, otherwise it is a bit more complicated