Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDS3 encoding options #85

Merged
merged 4 commits into from
Mar 27, 2021
Merged

PDS3 encoding options #85

merged 4 commits into from
Mar 27, 2021

Conversation

rbeyer
Copy link
Member

@rbeyer rbeyer commented Mar 20, 2021

Description

Added optional parameters (with specification-appropriate defaults) to pvl.encoder.PDSLabelEncoder().__init__() which allow users to optionally not write the trailing "Z" on time and datetime output, and also allow users to optionally make PVL Symbol Strings handled the same as PVL Text Strings (instead of handling them separately and enclosing them in single-quotes).

Related Issue

This would close #84.

How Has This Been Tested?

  • make lint
  • make docs
  • make test-all

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Licensing:

This project is released under the LICENSE.

  • I claim copyrights on my contributions in this pull request, and I provide those contributions via this pull request under the same license terms that the pvl project uses.

@rbeyer rbeyer merged commit b95d634 into planetarypy:main Mar 27, 2021
@rbeyer rbeyer deleted the PDSVariant-84 branch March 27, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We probably need a variant PDS3LabelEncoder().
1 participant