Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use spacings hooks #398

Merged
merged 4 commits into from
Jun 17, 2023
Merged

Add use spacings hooks #398

merged 4 commits into from
Jun 17, 2023

Conversation

luancurti
Copy link
Contributor

@luancurti luancurti commented Jun 15, 2023

Descrição do PR

Adicionado hook para calcular safe area juntamente com o padding utilizando spacings do fluid theme

Como Validei?

padding-bottom: 58px = 34px de safe area bottom + 24px do padding 'lg'
o padding-top ficou só com 24px que é o 'lg' pois existindo header não tem necessidade de colocar a safe area já que o header (da lib de navegação) já trata isso

Screenshot 2023-06-15 at 15 28 35

Tipo de mudança

  • Nova feature (mudança non-breaking que adiciona uma funcionalidade)
  • Bug fix (mudança non-breaking que conserta um problema)
  • Breaking change (ajuste ou funcionalidade que pode causar uma quebra numa funcionalidade já existente)
  • Chore (nenhuma das anteriores, como upgrade de libs)

Checklist 🚨

  • Testado usando Yalc
  • Meu código segue o code style da Builders
  • Meu código foi feito utilizando TDD (testes unitários obrigatórios)

@luancurti luancurti changed the title --wip-- [skip ci] Add use spacings hooks Jun 15, 2023
@luancurti luancurti marked this pull request as ready for review June 16, 2023 20:20
@luancurti luancurti self-assigned this Jun 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Merging #398 (4f5d6fe) into master (05790ae) will increase coverage by 15.10%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           master     #398       +/-   ##
===========================================
+ Coverage   83.72%   98.82%   +15.10%     
===========================================
  Files          15       15               
  Lines          86       85        -1     
  Branches       19       17        -2     
===========================================
+ Hits           72       84       +12     
+ Misses         14        1       -13     
Impacted Files Coverage Δ
src/native/useSpacingsWithSafeArea.ts 100.00% <100.00%> (ø)

@ammichael
Copy link
Collaborator

Complementando os prints do teste:
image

@ammichael ammichael merged commit 55e359b into master Jun 17, 2023
@ammichael ammichael deleted the chore/add-use-spacing-hook branch June 17, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants