Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #47: Document cgroups args changes #50

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

sibprogrammer
Copy link
Member

No description provided.

@vizovitin
Copy link
Contributor

While it would be slightly more secure to run with --cgroupns=private, which in general works, it seems to require more setup in some cases and may not work well on some configurations (didn't check the latter, so mostly speculation from my side).
So --cgroupns=host is probably not much worse than what we had before with Cgroups v1.

However, I propose to additionally add --cap-add SYS_ADMIN --security-opt apparmor=unconfined, which get rid of some warnings during init and some undesired behaviors during stop. Probably doesn't make the security much worse anyway.

For future reference:

@sibprogrammer sibprogrammer merged commit be911bc into master Jul 31, 2024
@vizovitin vizovitin deleted the bugfix-ayuzhakov-cgroupns branch July 31, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants