ADAPT-1570 Need a mechanism to validate logical types #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*added tests for comosite keys
irynabiletskaps
approved these changes
Jun 27, 2023
aman-minz
pushed a commit
that referenced
this pull request
Jun 28, 2023
* ADAPT-1570 Need a mechanism to validate logical types * ADAPT-1570 Need a mechanism to validate logical types *added tests for comosite keys --------- Co-authored-by: Mykola Nikulesko <mykola.nikulesko@agileengine.com>
irynabiletskaps
added a commit
that referenced
this pull request
Jul 11, 2023
This reverts commit 4ad29a4.
irynabiletskaps
added a commit
that referenced
this pull request
Jul 11, 2023
* Revert "fixing deps (#858)" This reverts commit 40b9b11. * Revert "fixing deps (#857)" This reverts commit 6bc5852. * Revert "update aws dependencies (#856)" This reverts commit 66b69ba. * Revert "update aws dependencies (#855)" This reverts commit bac43a4. * Revert "update aws dependencies (#854)" This reverts commit d471a8f. * Revert "ADAPT-1570 Need a mechanism to validate logical types (#851)" This reverts commit 4ad29a4. * Revert "ADAPT-1148: make msk arn env var as optional (#850)" This reverts commit b0ad90e. * Revert "ADAPT-1148: added msk rbac (#845)" This reverts commit 5fd5946. * Revert "Temporary revert (#859)" This reverts commit 62bd66b.
aman-minz
added a commit
that referenced
this pull request
Jul 26, 2023
) * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Fixing unit test cases - From Aman & Abhishek * Fix compilation issue and update tests * Add more tests * Add more tests * Remove unused import * Revert TopicDeletionProgramSpec as the methods call across modules fails * ADAPT-1566: add retries for getVersion and getAllVersions from schema… (#849) * ADAPT-1566: add retries for getVersion and getAllVersions from schema registry * ADAPT-1148: added msk rbac (#845) * ADAPT-1148: added msk rbac * ADAPT-1148: make msk arn env var as optional (#850) * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Fixing unit test cases - From Aman & Abhishek * Add more tests * Incorporate review comments * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Add more tests * Add test for InstantUtils and refactor * ADAPT-1570 Need a mechanism to validate logical types (#851) * ADAPT-1570 Need a mechanism to validate logical types * ADAPT-1570 Need a mechanism to validate logical types *added tests for comosite keys --------- Co-authored-by: Mykola Nikulesko <mykola.nikulesko@agileengine.com> * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Add test for InstantUtils and refactor * Incorporate review comments * Refactored and removed unwanted variables and methods * Store default loophole cutoff date in a variable * Fix failing unit test * Remove InstantUtils.scala * Update default loophole cut-off date --------- Co-authored-by: Abhishek <abhishek-verma@pluralsight.com> Co-authored-by: Iryna Biletska <93545362+irynabiletskaps@users.noreply.github.com> Co-authored-by: mnikulesko <96866310+mnikulesko@users.noreply.github.com> Co-authored-by: Mykola Nikulesko <mykola.nikulesko@agileengine.com>
aman-minz
added a commit
that referenced
this pull request
Aug 3, 2023
) * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Fixing unit test cases - From Aman & Abhishek * Fix compilation issue and update tests * Add more tests * Add more tests * Remove unused import * Revert TopicDeletionProgramSpec as the methods call across modules fails * ADAPT-1566: add retries for getVersion and getAllVersions from schema… (#849) * ADAPT-1566: add retries for getVersion and getAllVersions from schema registry * ADAPT-1148: added msk rbac (#845) * ADAPT-1148: added msk rbac * ADAPT-1148: make msk arn env var as optional (#850) * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Fixing unit test cases - From Aman & Abhishek * Add more tests * Incorporate review comments * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Add more tests * Add test for InstantUtils and refactor * ADAPT-1570 Need a mechanism to validate logical types (#851) * ADAPT-1570 Need a mechanism to validate logical types * ADAPT-1570 Need a mechanism to validate logical types *added tests for comosite keys --------- Co-authored-by: Mykola Nikulesko <mykola.nikulesko@agileengine.com> * ADAPT-1256: Close Default Loophole for fields - By Abhishek & Aman * Add test for InstantUtils and refactor * Incorporate review comments * Refactored and removed unwanted variables and methods * Store default loophole cutoff date in a variable * Fix failing unit test * Remove InstantUtils.scala * Update default loophole cut-off date --------- Co-authored-by: Abhishek <abhishek-verma@pluralsight.com> Co-authored-by: Iryna Biletska <93545362+irynabiletskaps@users.noreply.github.com> Co-authored-by: mnikulesko <96866310+mnikulesko@users.noreply.github.com> Co-authored-by: Mykola Nikulesko <mykola.nikulesko@agileengine.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tests for UUID and timestamps logical types for the V2 records endpoint.