fix: Correct semicolon placement in devtools middleware #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dai-shi
reviewed
Aug 27, 2024
| } | ||
| ;(originalDispatch as any)(...a) | ||
| } | ||
| originalDispatch(...a); |
|
I don't disagree with the readability, but it's how prettier formats, and we simply use prettier with minimal config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
Fixes #[Enter issue number here, or remove this line if there's no related issue]
Summary
This PR corrects the semicolon placement in the devtools middleware. Specifically, it adjusts the position of semicolons in the
dispatchfunction redefinition section, improving code readability and preventing potential Automatic Semicolon Insertion (ASI) related issues.Key changes:
const originalDispatchdeclarationdispatchfunction redefinitionoriginalDispatchcallThese changes improve code consistency and prevent potential syntax errors.
Check List
pnpm run prettierfor formatting code and docs