-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): improve v5 migration guide #2749
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Size Change: 0 B Total Size: 12 kB ℹ️ View Unchanged
|
) | ||
``` | ||
|
||
Here's another example that may cause infinite loops. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand why there is "another example," but the comment says that it's v4. Didn't you mean to say "Here's a similar example in v4 that may cause infinite loops?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean there are several cases that can cause infinite loops.
I want to show typical two examples that are actually reported by users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to make suggestions to clarify that.
Co-authored-by: Blazej Sewera <code@sewera.dev>
#2741 (comment)