Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow other UIResponders to respond to the shake event #63

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

colinhumber
Copy link
Contributor

If other components in an app respond to the shake and are further up the responder chain from UIViewController they won't receive the events as they are consumed within the UIViewController extension in WHBaseViewController. Passing the event up allows those responders to handle the event as required.

@pmusolino
Copy link
Owner

Thanks for this PR @colinhumber!

@pmusolino pmusolino added the enhancement New feature or request label Sep 18, 2019
@pmusolino pmusolino merged commit a40712c into pmusolino:master Sep 18, 2019
@colinhumber colinhumber deleted the shake-fix branch September 18, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants