Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set priority of presentedViewController in currentViewController func to high #86

Closed
wants to merge 2 commits into from

Conversation

farhad01
Copy link

fixes issue when UITabBarController.topViewController is nil but its presenting sth

… to high

fixes issue when UITabBarController.topViewController is nil but its presenting sth
@pmusolino pmusolino self-requested a review September 7, 2020 10:24
@pmusolino
Copy link
Owner

Hi there, and sorry for the delay! How to test it? What is the case when the topViewController of a UITabBarController isnil?

@farhad01
Copy link
Author

farhad01 commented Sep 7, 2020

No problem :)), in my case the login page could present over the tabBar occasionally and the first time user enters the tabBar has no content yet until login.

To test:
set rootVC tabBar(don't embed any vc in the tabBar)
present a vc over
shake

@pmusolino
Copy link
Owner

Since the library changed a lot in over a year, I'm going to close this PR. Feel free to re-open it if this issue still occurs.

@pmusolino pmusolino closed this Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants