Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix automatic shutdown verification logic #47

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Fix automatic shutdown verification logic #47

merged 4 commits into from
Sep 30, 2024

Conversation

lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented Sep 26, 2024

No description provided.

@yunjoonjung-PNNL
Copy link
Collaborator

@lymereJ I added the unit testing. Additionally, I tested your new logic with our previos test case - ASHRAE901_OfficeSmall_STD2019_Seattle.idf and passed as expected.

I appreciate for fixing this logic.

@lymereJ lymereJ marked this pull request as ready for review September 26, 2024 18:40
leijerry888
leijerry888 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@leijerry888 leijerry888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added docstring from design md (on internal animate repo)

@leijerry888 leijerry888 merged commit 4746560 into develop Sep 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leijerry888 leijerry888 leijerry888 approved these changes

@yunjoonjung-PNNL yunjoonjung-PNNL yunjoonjung-PNNL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lymereJ @yunjoonjung-PNNL @leijerry888