Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Webpack 4, cleanup #266

Merged
merged 4 commits into from
Oct 4, 2018
Merged

Adding support for Webpack 4, cleanup #266

merged 4 commits into from
Oct 4, 2018

Conversation

patrick-rodgers
Copy link
Member

Category

  • Bug fix?
  • New feature?
  • New sample?
  • Documentation update?

Related Issues

none

What's in this Pull Request?

  • Adds support for webpack 4
  • Project cleanup
  • Enable webpack.config.js in root
  • Clean up deps
  • Optimize serve
  • Various small changes and trimming where possible.

@patrick-rodgers patrick-rodgers added this to the 1.2.2 milestone Oct 4, 2018
@patrick-rodgers
Copy link
Member Author

@koltyakov - if you get a chance please pull this down and do a quick sanity check that things work. You can debug, build, etc. This and the other PR of mine I already merged updated most of the tooling so want to make sure there aren't any "it works on my machine" moments. I also removed some stuff that is no longer used from package.json

@koltyakov
Copy link
Member

@patrick-rodgers checking it now, btw. Will let you know shortly.

@patrick-rodgers
Copy link
Member Author

On the upside all the build/debug tasks should run faster now :)

@koltyakov
Copy link
Member

Build tasks work well on my (win) machine. Build time improvement is significant. Great job!
Can't check on macOS right now, but at least testing on another machine should reduce potential "it works on my machine" moments.
Tests went well (with the exception of webhooks and taxonomy which I didn't configure properly here on the environment). Everything looks cool!

@patrick-rodgers
Copy link
Member Author

Thanks! I wouldn't worry about testing on mac, the cli tests should catch any issues around filename casing etc. I will go ahead and merge this then and update changelog. Appreciate you taking a look.

@patrick-rodgers patrick-rodgers merged commit 62f14e9 into pnp:dev Oct 4, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants