Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for building documentation using MkDocs #315

Merged
merged 2 commits into from
Oct 30, 2018
Merged

Fix documentation for building documentation using MkDocs #315

merged 2 commits into from
Oct 30, 2018

Conversation

KEMiCZA
Copy link
Contributor

@KEMiCZA KEMiCZA commented Oct 29, 2018

Category

  • Bug fix?
  • New feature?
  • New sample?
  • Documentation update?

What's in this Pull Request?

The documentation build method was changed to MkDocs, but the documentation for this was never updated. For more information see #206

The documentation build method was changed to MkDocs, but the documentation for this was never updated. For more information see #206
@KEMiCZA KEMiCZA closed this Oct 29, 2018
Made a different chapter for how to build the documentation
@KEMiCZA KEMiCZA reopened this Oct 29, 2018
@KEMiCZA
Copy link
Contributor Author

KEMiCZA commented Oct 29, 2018

I was not sure about where to put this information exactly. I created a new documentation "chapter" and put the info there. Let me know what you think.
Looks like this now:
image

@patrick-rodgers patrick-rodgers merged commit c021b50 into pnp:dev Oct 30, 2018
@patrick-rodgers
Copy link
Member

Thanks, great addition to the docs. I added a few sentences and changed the nav to "Build Docs" Thanks!

@patrick-rodgers patrick-rodgers added this to the 1.2.4 milestone Oct 30, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants