added more parameters to list subscription update method #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make clientState optional, remove default value "pnp-js-core-subscription"
|
Did also some tests. With this update, if you call it without any parameters (which is possible as all parameters are now optional), the actual rest call is not failing, it jus and it doesn't update anything with empty body, nice. |
|
Not sure how it will merge but it looks like this branch doesn't have the update to the add method you submitted in another PR. Do you want to refresh this branch to ensure it has the latest before I merge? Would hate to overwrite your other change. |
…t-subscription-optional-parameters
|
I think I got it merged all right. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
What's in this Pull Request?
While refactoring the list subscription add method, realised that when updating the list subscription, you can update all the parameters: expirationDate and notificationUrl and clientState, before it was only possible to update the expirationDate. So I made all the parameters optional in the update method. I was wondering should we create methods for each case?
Also this should be backward compatible with earlier PnPjs versions.