Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bobg #122

Merged
merged 3 commits into from
Apr 6, 2018
Merged

Bobg #122

merged 3 commits into from
Apr 6, 2018

Conversation

BobGerman
Copy link
Contributor

Q A
Bug fix? no
New feature? no
New sample? yes
Related issues?

What's in this Pull Request?

New sample shows how to build a header (containing a navigation menu) and a footer that work on both modern and classic SharePoint sites. SharePoint Framework web parts work on classic sites, but SPFx extensions do not; this demonstrates an approach for headers and footers, which are visible and often related to usability and compliance.

@BobGerman
Copy link
Contributor Author

Updated documentation format per Vesa's request; also submitting to the correct branch this time! (Next time I'll read the contribution guidelines first!)

@VesaJuvonen VesaJuvonen merged commit 702f546 into pnp:dev Apr 6, 2018
@VesaJuvonen
Copy link
Contributor

thx Bob, appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BobGerman @VesaJuvonen