Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded SPFx version to 1.19.0 #1402

Merged
merged 4 commits into from
Sep 1, 2024
Merged

Upgraded SPFx version to 1.19.0 #1402

merged 4 commits into from
Sep 1, 2024

Conversation

HarminderSethi
Copy link
Contributor

Q A
Bug fix/update? yes
New feature? no
New sample? no
Related issues? no

What's in this Pull Request?

Upgraded SPFx version to 1.19.0 for react-utility-extension sample

});
// event to handle changes to the search input box
var searchInputChange = function () {
searchPanel.innerHTML = "<div>" + strings.PanelTextPrefix + " <b>" + searchBoxInput.value + "</b></div>";

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
HeaderSearchBoxApplicationCustomizer.prototype.handleSearchRedirect = function (searchQuery) {
if (searchQuery && searchQuery.trim().length > 0) {
console.log(strings.LogRedirectingTo + " " + this.searchResultPage);
window.location.href = this.searchResultPage + "?k=" + searchQuery;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
DOM text
is reinterpreted as HTML without escaping meta-characters.
DOM text
is reinterpreted as HTML without escaping meta-characters.

// event to handle changes to the search input box
const searchInputChange = () => {
searchPanel.innerHTML = `<div>${strings.PanelTextPrefix} <b>${searchBoxInput.value}</b></div>`;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
private handleSearchRedirect(searchQuery: string) {
if (searchQuery && searchQuery.trim().length > 0) {
console.log(`${strings.LogRedirectingTo} ${this.searchResultPage}`);
window.location.href = `${this.searchResultPage}?k=${searchQuery}`;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
DOM text
is reinterpreted as HTML without escaping meta-characters.
DOM text
is reinterpreted as HTML without escaping meta-characters.
const hasPermission = this.context.pageContext.list.permissions.hasPermission(SPPermission.editListItems);

const copySettingsCommand: Command = this.tryGetCommand('COPY_SETTINGS');
const fillColor = getThemeColor("themeDarkAlt").replace('#', '%23');

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High

This replaces only the first occurrence of '#'.
@hugoabernier hugoabernier merged commit be18c54 into pnp:main Sep 1, 2024
@hugoabernier
Copy link
Collaborator

Thank you @HarminderSethi for your update! Awesome!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants