-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded SPFx version to 1.19.0 #1402
Conversation
}); | ||
// event to handle changes to the search input box | ||
var searchInputChange = function () { | ||
searchPanel.innerHTML = "<div>" + strings.PanelTextPrefix + " <b>" + searchBoxInput.value + "</b></div>"; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
DOM text
HeaderSearchBoxApplicationCustomizer.prototype.handleSearchRedirect = function (searchQuery) { | ||
if (searchQuery && searchQuery.trim().length > 0) { | ||
console.log(strings.LogRedirectingTo + " " + this.searchResultPage); | ||
window.location.href = this.searchResultPage + "?k=" + searchQuery; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
DOM text
DOM text
DOM text
|
||
// event to handle changes to the search input box | ||
const searchInputChange = () => { | ||
searchPanel.innerHTML = `<div>${strings.PanelTextPrefix} <b>${searchBoxInput.value}</b></div>`; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
DOM text
private handleSearchRedirect(searchQuery: string) { | ||
if (searchQuery && searchQuery.trim().length > 0) { | ||
console.log(`${strings.LogRedirectingTo} ${this.searchResultPage}`); | ||
window.location.href = `${this.searchResultPage}?k=${searchQuery}`; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
DOM text
DOM text
DOM text
const hasPermission = this.context.pageContext.list.permissions.hasPermission(SPPermission.editListItems); | ||
|
||
const copySettingsCommand: Command = this.tryGetCommand('COPY_SETTINGS'); | ||
const fillColor = getThemeColor("themeDarkAlt").replace('#', '%23'); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Thank you @HarminderSethi for your update! Awesome!. Thank you for sharing your sample with others - you rock! 👏🥇👩💻 |
What's in this Pull Request?