Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [Feature]: make walkthrough button more visible in welcome experience #261

Closed
Adam-it opened this issue Jun 30, 2024 · 3 comments
Closed
Assignees
Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 👨‍💻work in progress I am working on it

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Jun 30, 2024

🎯 Aim of the feature

The aim is to make the walkthrough button more visible in the welcome view.
Currently, it is presented as a simple link at the bottom

image

The aim is to refactor it to a separate button instead of a link that could be under the 'Install dependencies' button. It could have a header above it like "Learn more about SharePoint Framework and this toolkit"

📷 Images (if possible) with expected result

image

🤔 Additional remarks or comments

in VS Code the welcome experience is fully created based on a string 😱 added directly in package.json
image

currently there is no way to improve/extract it and this is how it is suppose to be done according to the docs.

https://code.visualstudio.com/api/ux-guidelines/views#welcome-views

this is the part that needs to be extended

@Adam-it Adam-it added ⭐ enhancement New feature or request 💪 good first issue Good for newcomers 🙏 help wanted Open for contributors labels Jun 30, 2024
@DevPio
Copy link
Contributor

DevPio commented Jul 11, 2024

I would like to work on this problem

@Adam-it
Copy link
Contributor Author

Adam-it commented Jul 11, 2024

I would like to work on this problem

Sure thing👍
You Rock 🤩👏

@Adam-it Adam-it added 👨‍💻work in progress I am working on it and removed 🙏 help wanted Open for contributors labels Jul 11, 2024
Adam-it pushed a commit that referenced this issue Jul 12, 2024
## 🎯 Aim

The previous text was replaced with a button

## 📷 Result

![image](https://github.com/user-attachments/assets/6cde9cf1-bd90-45bd-91b4-8db51d9dbce5)

## 🔗 Related issue

Closes: #261
@Adam-it
Copy link
Contributor Author

Adam-it commented Jul 12, 2024

The related PR got merged and will be part of next pre-release shortly
After that it will be merged to main and part of next minor release in the following days.
Thank you for your awesome work 👏👏👏
You Rock 🤩

@Adam-it Adam-it closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 👨‍💻work in progress I am working on it
Projects
None yet
Development

No branches or pull requests

2 participants