Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup, etc. #21

Merged
merged 4 commits into from
Aug 10, 2017
Merged

Cleanup, etc. #21

merged 4 commits into from
Aug 10, 2017

Conversation

stephencelis
Copy link
Member

@stephencelis stephencelis commented Aug 10, 2017

Big, breaking changes.

  1. Got rid of assertSnapshot(encoding:)—didn't seem worth it. The Any check is more powerful and strict.
  2. Got rid of the trailing closure record { … } API and instead added record: true to the assertion itself.
  3. Recording always causes a test assertion failure. This lets us quickly check what was recorded by looking at the Xcode error and avoids letting unrecorded assertions get checked in and pass CI.
  4. String diff failures use a new diff format. This is easier to read than a general call to XCTAssertEqual.
    screen shot 2017-08-09 at 11 40 14 pm
  5. Snapshots are now grouped at the test file level (rather than test directory level). This means more directory groupings with shorter file names that are easier to scan in GitHub pull requests.
  6. Multiple snapshots in a single test will increment automatically. This makes sorting through snapshots chronologically easier. It all means setting a snapshot name is optional.

@stephencelis
Copy link
Member Author

(This fixes #19 and #20 when merged.)

@stephencelis stephencelis merged commit 1507864 into master Aug 10, 2017
@stephencelis stephencelis deleted the cleanup-and-nsobjects branch August 10, 2017 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants