Generic Snapshots #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Jul 9, 2017
| let image = UIGraphicsGetImageFromCurrentImageContext()! | ||
| UIGraphicsEndImageContext() | ||
| let data = UIImagePNGRepresentation(image)! | ||
| var diffTool: String? = nil |
There was a problem hiding this comment.
Can assign this "ksdiff", e.g., to print out a Kaleidoscope line.
| + ".png" | ||
|
|
||
| let snapshotURL = URL(string: snapshotName, relativeTo: snapshotsDirectoryURL)! | ||
| public protocol Diffable { |
There was a problem hiding this comment.
This protocol is used to describe types that can be diffed (images, text).
| try! data.write(to: snapshotURL) | ||
| return nil | ||
| } | ||
| public protocol Snapshot { |
There was a problem hiding this comment.
This protocol describes types that can have snapshots taken, deferring to a Diffable type.
| ) | ||
|
|
||
| return attachment | ||
| XCTContext.runActivity(named: "Attached failure diff") { activity in activity.add(attachment) } |
There was a problem hiding this comment.
Don't need to return attachment anymore!
stephencelis
force-pushed
the
generic-snapshots
branch
from
23f6664
to
2a250f2
Compare
mbrandonw
approved these changes
Jul 9, 2017
| } | ||
|
|
||
| public func diff(comparing other: Data) -> XCTAttachment? { | ||
| return nil |
There was a problem hiding this comment.
should we at least just do an attachment of a string with current: \(self)\nnew: \(other) or something?
There was a problem hiding this comment.
Probably! I'll try to improve these soon.
| ) | ||
|
|
||
| return attachment | ||
| XCTContext.runActivity(named: "Attached failure diff") { activity in activity.add(attachment) } |
| let image = UIGraphicsGetImageFromCurrentImageContext()! | ||
| UIGraphicsEndImageContext() | ||
| return image | ||
| return |
tokopedia-ios-bot
pushed a commit
to tokopedia-ios-bot/swift-snapshot-testing
that referenced
this pull request
Mar 22, 2021
[Update Fork] Make image diffing strategies custom scale aware (pointfreeco#336)
niil-qb
pushed a commit
to quickbit/swift-snapshot-testing
that referenced
this pull request
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a mess, naming/protocol-wise, and can probably be cleaned up quite a bit, but it's a start.